Repository navigation
fix: follow-ups from the docs sync - #107
Merged
Merged
Conversation
…ause The failure counter never reset, so after 3 failed multicast sends in total over a mount, a node sent invalidations only to unicast peers until it unmounted. Now a successful send resets the count, and after MaxMulticastFailures failures in a row the node sends only to unicast peers for 30 seconds before it tries multicast again. The total stays in TransportStats; /metrics does not export broadcast counters. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Nothing read it. A checkpoint already runs every 5 seconds and is forced when a transaction does not fit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ager -sfb defaulted to true and logged "SFB: enabled", but nothing used the SFB manager it created: writes never allocate slots, and reading, migrating and freeing old slots does not go through it. Mount now logs what is in effect and still accepts -sfb. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
make test-integration ran the full suite with a 5 minute timeout; it takes about 15 minutes, so allow 30 and say so in make help. goclusterfs-fsck -h said repair never frees blocks or deletes inodes, which changed with #72 and #86, and the api package doc called the API read-only, which changed with #57. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The small items from #99's list, one commit each:
FullThresholdis removed, not wired in. Checkpoints run every 5 s and when a transaction doesn't fit.make test-integrationtimeout 5m → 30m.Checked on .68 at 34500f1: build, vet, lint 0, race tests for the touched packages, the new log and help text.
Not done:
/metricsexports no broadcast counters, so it needs no change.Found:
internal/goclusterfstook 861 s under-raceon .68. That is overmake test-unit's default 10-minute timeout.🤖 Generated with Claude Code