Skip to content

fix: follow-ups from the docs sync - #107

Merged
mattmattox merged 4 commits into
mainfrom
claude/small-fixes-after-99
Nov 13, 2026
Merged

mattmattox merged 4 commits into
mainfrom
claude/small-fixes-after-99

Conversation

@mattmattox

Copy link
Copy Markdown
Contributor

The small items from #99's list, one commit each:

  • Multicast failures now count only in a row. A success resets them, and after 3 the node uses unicast for 30 s, then retries.
  • FullThreshold is removed, not wired in. Checkpoints run every 5 s and when a transaction doesn't fit.
  • Mount logs that SFB is disabled and drops the unused SFB manager.
  • make test-integration timeout 5m → 30m.
  • fsck repair help and the api package doc are updated.

Checked on .68 at 34500f1: build, vet, lint 0, race tests for the touched packages, the new log and help text.

Not done:

  • CLAUDE.md's v2 layout is unchanged; it needs the user's go-ahead.
  • /metrics exports no broadcast counters, so it needs no change.

Found: internal/goclusterfs took 861 s under -race on .68. That is over make test-unit's default 10-minute timeout.

🤖 Generated with Claude Code

mattmattox and others added 4 commits November 13, 2026 15:01
…ause

The failure counter never reset, so after 3 failed multicast sends in
total over a mount, a node sent invalidations only to unicast peers
until it unmounted. Now a successful send resets the count, and after
MaxMulticastFailures failures in a row the node sends only to unicast
peers for 30 seconds before it tries multicast again. The total stays
in TransportStats; /metrics does not export broadcast counters.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Nothing read it. A checkpoint already runs every 5 seconds and is
forced when a transaction does not fit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ager

-sfb defaulted to true and logged "SFB: enabled", but nothing used the
SFB manager it created: writes never allocate slots, and reading,
migrating and freeing old slots does not go through it. Mount now logs
what is in effect and still accepts -sfb.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
make test-integration ran the full suite with a 5 minute timeout; it
takes about 15 minutes, so allow 30 and say so in make help.

goclusterfs-fsck -h said repair never frees blocks or deletes inodes,
which changed with #72 and #86, and the api package doc called the API
read-only, which changed with #57.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mattmattox
mattmattox merged commit 30220f4 into main Nov 13, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant