Repository navigation
fix(snapshot): let a second delete job leave a reused data inode alone - #103
Merged
Merged
Conversation
A job that read the descriptor before another job of the same snapshot freed the data inode could then empty whatever took that slot, such as a new snapshot's data inode. The job now empties the data inode under its lock and only while the descriptor still names it, runs one at a time per node, and succeeds when it finds the snapshot already removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two delete jobs for one snapshot can run at the same time. Mount recovery queues a job for every deleting snapshot, including one another node is deleting right now, and a double delete queues two. A job that read the descriptor before the other job freed the data inode then emptied whatever took that slot. On main,
TestSecondDeleteJobLeavesReusedDataInodeshows a new snapshot in that slot losing its blocks (refcount 2 → 1), and the second job fails in both cases.The guard checks the descriptor rather than a generation. The descriptor goes before the inode is freed, so "still named, checked under the inode lock" proves the slot was not reused. A generation read after the descriptor could already belong to the new inode.
🤖 Generated with Claude Code