Repository navigation
feat(mount): log slow shutdown steps and dump goroutines when an unmount stalls - #101
Merged
Merged
Conversation
…unt stalls One container restart in a Docker round took 27s because its mount ignored SIGTERM for 10s, and nothing showed why. A shutdown step that takes longer than 2s now logs its name and duration, and a shutdown still running after 8s logs every goroutine's stack, so the next stall explains itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # cmd/mount/main.go # tests/test-manifest.yaml
A busy unmount leaves the mount serving, but the watch started by the signal still dumped every goroutine after 8s as a stalled shutdown. The watch now ends when the unmount fails, and the next signal, or the unmount another tool finishes, starts a new one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small and not urgent; the PM asked for it after the SIGTERM chase.
In one #29 Docker round, a container's mount ignored SIGTERM for 10s and nothing showed why. I couldn't reproduce it: 5 rounds on main with 139 SIGTERM stops all exited within a second, and every shutdown step took at most 11ms. So the mount now explains a stall itself:
shutdown: <step> took <time>. The steps covered are the API server, registry and broadcast stops, unmount, and each step insideFS.Close(snapshot worker, TRIM, journal, lock release, device close).TROUBLESHOOTING.md describes both. Each of the two tests fails with its check removed.
🤖 Generated with Claude Code