You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@michaelblyons in my local fork I have marked the ambiguous float long syntax as invalid.deprecated, because Microsoft themselves discourage people from using it. Should I send a PR?
Sure! DeathAxe is usually not excited about deprecation marking, but this case was always ambiguous. And now that there's official guidance, I think it makes sense.
@michaelblyons Thank you! I'd like to resolve #186 before sending in this new PR. One thing I don't understand, though, is the error
error: unexpected symbol `$x` (definition) found
note: all symbols must be matched unless `partial-symbols` is specified
528 | $x..5.40D
| @@ this `definition` is not tested for
Which pops up for every variable present in the test while testing it on my local Sublime Text. I tried googling it, but I couldn't find any relevant results. Why is the definition not tested for?
If you test for any symbols matching, it tests for all symbols unless you have partial-symbols in the first line. Any symbol encountered without a test is a failure without that first line instruction.
Activity
deathaxe commentedon Jan 6, 2025
Why disable tests instead of fixing failing syntax test assertions?
michaelblyons commentedon Jan 6, 2025
Also a possibility. Some of them don't really make sense though. IIRC there are some number suffix things that no one would use.
matteocoder commentedon Jan 8, 2025
@michaelblyons in my local fork I have marked the ambiguous float long syntax as
invalid.deprecated, because Microsoft themselves discourage people from using it. Should I send a PR?michaelblyons commentedon Jan 8, 2025
Sure! DeathAxe is usually not excited about deprecation marking, but this case was always ambiguous. And now that there's official guidance, I think it makes sense.
matteocoder commentedon Jan 8, 2025
@michaelblyons Thank you! I'd like to resolve #186 before sending in this new PR. One thing I don't understand, though, is the error
Which pops up for every variable present in the test while testing it on my local Sublime Text. I tried googling it, but I couldn't find any relevant results. Why is the
definitionnot tested for?michaelblyons commentedon Jan 8, 2025
If you test for any symbols matching, it tests for all symbols unless you have
partial-symbolsin the first line. Any symbol encountered without a test is a failure without that first line instruction.matteocoder commentedon Jan 8, 2025
I see. So to solve these kinds of errors there should be a test for each variable name?
michaelblyons commentedon Jan 8, 2025
Your options are
partial-symbolsto the first line afterSYNTAX TESTbefore the file path to the syntax file.See https://www.sublimetext.com/docs/syntax.html#testing
matteocoder commentedon Jan 8, 2025
I understand now, thank you!