You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I believe that the Editor-Syntax repository has had a few bug fixes upstream since it was copied for use in this repo. Would it make sense to have it as a git submodule, to make it easier to see which version is currently being used by this package, and easier to update this package to use the latest version?
Good question - Package Control just uses GitHub's zip download feature, so I guess it depends whether submodules are included in the zip or not. I will try to investigate this, thanks.
Thank you, Keith, for taking a look at it. I was too lazy to investigate it properly. If it turns out that it doesn't, we can include a file with a commit sha and a script to auto-update it, something like that.
Could you (hard|soft|sym)link to the file that lives in the submodule such that GitHub adds it to the zip? And make a script to convert the file (if Git thinks the link is a file) into a link to be run after clone?
Activity
vors commentedon Jul 28, 2018
ST package manager currently uses master for install. Can it work with submodules? If so, we should do that.
keith-hall commentedon Jul 28, 2018
Good question - Package Control just uses GitHub's zip download feature, so I guess it depends whether submodules are included in the zip or not. I will try to investigate this, thanks.
vors commentedon Jul 28, 2018
Thank you, Keith, for taking a look at it. I was too lazy to investigate it properly. If it turns out that it doesn't, we can include a file with a commit sha and a script to auto-update it, something like that.
keith-hall commentedon Jul 29, 2018
I have tested, and GitHub doesn't include submodules in the zip file. Your auto update script idea sounds like a good one.
michaelblyons commentedon Mar 26, 2019
Could you (hard|soft|sym)link to the file that lives in the submodule such that GitHub adds it to the zip? And make a script to convert the file (if Git thinks the link is a file) into a link to be run after
clone?vors commentedon Apr 21, 2019
Not sure is it possible or not. Currently there is no submodule because I don't know how sublime packages with submodules work.
michaelblyons commentedon Dec 21, 2024
Obsoleted by #165?