Skip to content

Rework delete_items to use mediawiki API action=delete. - #131

Merged
andrawaag merged 2 commits into
SuLab:masterfrom
LeMyst:delete_item_rework
May 24, 2020
Merged

andrawaag merged 2 commits into
SuLab:masterfrom
LeMyst:delete_item_rework

Conversation

@LeMyst

@LeMyst LeMyst commented May 20, 2020

Copy link
Copy Markdown
Contributor

This is a breaking change, the function become delete_item() instead of delete_items(), and now take a unique QID instead of a list.
The user need to have "delete"/"administrator" rights to perform the action.

@LeMyst
LeMyst marked this pull request as draft May 20, 2020 18:17
@LeMyst
LeMyst force-pushed the delete_item_rework branch from 9c309aa to 34db80e Compare May 20, 2020 18:35
This is a breaking change, the function become delete_item instead of delete_items, and now take a unique QID instead of a list.
@LeMyst
LeMyst force-pushed the delete_item_rework branch from 34db80e to 447063e Compare May 20, 2020 18:41
@LeMyst

LeMyst commented May 21, 2020

Copy link
Copy Markdown
Contributor Author

@andrawaag
Does I use the WDUSER and WDPASS to create a WDLogin object and pass it to the delete_item?
And if no WDUSER/WDPASS provided, I dont do the test?

@LeMyst
LeMyst marked this pull request as ready for review May 21, 2020 15:39
@andrawaag
andrawaag merged commit 0eb6676 into SuLab:master May 24, 2020
@LeMyst
LeMyst deleted the delete_item_rework branch July 24, 2020 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants