Skip to content

fix: Run again starts the new run (v1.2.1) - #84

Merged
StuartMeeks merged 2 commits into
mainfrom
fix/run-again-reused-terminal
Nov 18, 2026
Merged

StuartMeeks merged 2 commits into
mainfrom
fix/run-again-reused-terminal

Conversation

@StuartMeeks

Copy link
Copy Markdown
Owner

Summary

  • Bug: clicking Run again from a run's output view left the header at "Starting…" with no output.
  • Cause: WinUI reuses the run DataTemplate (and its TerminalView) when one run view replaces another. The control was handed the new CommandRunViewModel after it had already wired up, so TryWire bailed and StartAsync was never called. The old run's OutputReceived handler also stayed attached.
  • Fix: on a view-model change, TerminalView detaches the old run and posts a new reset message; terminal.html resets xterm, re-fits (re-sending size to the new PTY runner) and re-signals ready, which wires and starts the new run.
  • Release commit bumps version.json to 1.2.1 and promotes the CHANGELOG.

Testing

  • Solution builds clean on PROPHET (0 warnings, 0 errors).
  • Manually verified with a test build on PROPHET: Run again from a live run and from History.

After merge

Tag the merge commit v1.2.1 to trigger the release workflow.

🤖 Generated with Claude Code

StuartMeeks and others added 2 commits November 18, 2026 04:38
WinUI reuses the run DataTemplate when one run view replaces another, so
TerminalView was handed the new view model after it had already wired up
and never started it, leaving the header at "Starting…". Detach the old
run, reset xterm, and rewire once the page re-reports size and readiness.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bump version.json to 1.2.1 and promote the CHANGELOG: Run again from a
run's output view now starts the new run instead of sticking at
"Starting…".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@StuartMeeks
StuartMeeks merged commit c899e2d into main Nov 18, 2026
8 checks passed
@StuartMeeks
StuartMeeks deleted the fix/run-again-reused-terminal branch November 18, 2026 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant