Repository navigation
fix: Run again starts the new run (v1.2.1) - #84
Merged
Merged
Conversation
WinUI reuses the run DataTemplate when one run view replaces another, so TerminalView was handed the new view model after it had already wired up and never started it, leaving the header at "Starting…". Detach the old run, reset xterm, and rewire once the page re-reports size and readiness. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bump version.json to 1.2.1 and promote the CHANGELOG: Run again from a run's output view now starts the new run instead of sticking at "Starting…". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DataTemplate(and itsTerminalView) when one run view replaces another. The control was handed the newCommandRunViewModelafter it had already wired up, soTryWirebailed andStartAsyncwas never called. The old run'sOutputReceivedhandler also stayed attached.TerminalViewdetaches the old run and posts a newresetmessage;terminal.htmlresets xterm, re-fits (re-sending size to the new PTY runner) and re-signalsready, which wires and starts the new run.version.jsonto 1.2.1 and promotes the CHANGELOG.Testing
After merge
Tag the merge commit
v1.2.1to trigger the release workflow.🤖 Generated with Claude Code