Skip to content

Version history? #7

Open
Open

Description

@wesleytodd

What is happening in there? Were all those versions actually published? If not, you should try to clean up the git history to reflect what is actually in npm. If they were, then maybe figuring out what went wrong so it doesn't happen again in the future would be worth it.

CC: @nickroberts404 @vstreamme

Activity

  1. vstreamme commented on Feb 26, 2018

    @vstreamme
    Contributor

    Hi!

    Yeah we had some strange issues the other day around this package. This issue in particular seems due to a NPM problem I was experiencing at the time, we couldn't figure it out so Nick published it for me. We had a large group DM chat between the involved people in slack.

  2. wesleytodd commented on Feb 26, 2018

    @wesleytodd
    ContributorAuthor

    So the question stands: Where all those versions actually published to npm?

  3. wesleytodd commented on Feb 26, 2018

    @wesleytodd
    ContributorAuthor
    $ npm info @streammedev/flyout
    
    { name: '@streammedev/flyout',
      description: 'An html flyout component',
      'dist-tags': { latest: '1.0.6', next: '1.0.1-BETA-1' },
      versions:
       [ '0.0.1',
         '0.0.2',
         '0.0.3',
         '0.0.4',
         '0.0.5',
         '0.0.6',
         '1.0.0-BETA-1',
         '1.0.0-RC-1',
         '1.0.0-RC-2',
         '1.0.0-RC-3',
         '1.0.0',
         '1.0.1-BETA-1',
         '1.0.6' ],
    // ...
    

    It looks like they were not. So you should rebase the git history here and then force push over so that the git history matches the actual publish history.

  4. vstreamme commented on Feb 26, 2018

    @vstreamme
    Contributor

    I agree, thanks for catching it :) I will make sure to let everyone involved knows of this.

    👍

  5. vstreamme commented on Feb 26, 2018

    @vstreamme
    Contributor

    All clean!

  6. wesleytodd commented on Feb 26, 2018

    @wesleytodd
    ContributorAuthor

    So I am still confused. Now that it is clean it looks like it jumped straight from 0.0.6 to 1.0.6. But there is a publish for 1.0.0? Where did that go?

    Also, there is an open PR for a bunch of crap, supposedly for 1.0. I don't know what was all in there even though I wrote it (lol).

  7. vstreamme commented on Feb 26, 2018

    @vstreamme
    Contributor

    Not sure, we are gonna see if your branch is compatible with the packages that use the master branch and we will merge and close it if it does.

  8. amberleyromo commented on Feb 28, 2018

    @amberleyromo
    Member

    I happen to have an old repo history pulled (haven't fetched since this happened) and it looks like the 1.0.0 commit got written over / rewritten during your rebase @vstreamme, so it now reflects the 1.0.6. Just in case the log is helpful for context here:

    commit 936629fd492d69fd38b27bd8839b6f59e5722c50 (HEAD -> master, origin/master, origin/HEAD)
    Author: Virginia Carrasco <virginia@stream.me>
    Date:   Thu Feb 22 12:33:50 2018 -0500
    
        1.0.5
    
    commit 213e443d7d1b22999ad83352f073a0da59329144
    Author: Virginia Carrasco <virginia@stream.me>
    Date:   Thu Feb 22 12:29:50 2018 -0500
    
        1.0.4
    
    commit 4449f78e50b14ad2517ebebd3694f6f5097c2bea
    Author: Virginia Carrasco <virginia@stream.me>
    Date:   Thu Feb 22 12:29:44 2018 -0500
    
        removal of npmrc
    
    commit b0024aef36d7c68d3fe06a4f014eccb7f1471adf
    Author: Virginia Carrasco <virginia@stream.me>
    Date:   Thu Feb 22 12:01:32 2018 -0500
    
        1.0.3
    
    commit b6bc6a873832c80fbcedce59a35099055e98d8ea
    Author: Virginia Carrasco <virginia@stream.me>
    Date:   Thu Feb 22 12:01:26 2018 -0500
    
        added npmrc
    
    commit 0ff6766713f30b3e5bb50421631ae54ba6dcf359
    Author: Virginia Carrasco <virginia@stream.me>
    Date:   Thu Feb 22 11:29:00 2018 -0500
    
        1.0.2
    
    commit bd3ab13dbe92170eb6f2fba52ba6774bbd8294a7
    Author: Virginia Carrasco <virginia@stream.me>
    Date:   Thu Feb 22 11:28:54 2018 -0500
    
        added npmrc
    
    commit 9114126d00f82daffb05c2cc0de0a0c34ffcb574
    Author: Virginia Carrasco <virginia@stream.me>
    Date:   Thu Feb 22 10:49:59 2018 -0500
    
        1.0.1
    
    commit a31fecf8b3b7ab07af42e0ed7c7b741b6574bd10
    Author: Virginia Carrasco <virginia@stream.me>
    Date:   Thu Feb 22 10:49:46 2018 -0500
    
        flyout content fixes
    
    commit e6dbee1534911666fca2af8593650030c83877da
    Author: Nick Roberts <nick@stream.me>
    Date:   Wed Nov 29 14:07:41 2017 -0600
    
        1.0.0
    
    commit 4d6986ad1dfa2346bb62cfe0f73459a0b78453d3
    Author: Nick Roberts <nick@stream.me>
    Date:   Wed Nov 29 11:01:27 2017 -0600
    
        Added react to devDep for testing, removed react-dom
    
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions