[dmccoystephenson]

Summary

• Save-compatibility gate (Save-compat: stderr after a scenario's JSON line fails the read as a verdict on the candidate #18): view() took the last output line as the view, and common.run() places stderr after stdout, so a library warning failed a correct read as a verdict on the candidate. The view is now read by a new pure helper, parse_view(), as the last line holding a JSON object. Output with no such line still fails, and a non-zero exit is still returned unchanged. A view that is not an object (previously accepted by view()) is now rejected; every scenario in scenarios/ prints an object.
• Consumers gate (Consumers gate: a repository URL matches any longer repository name as a pin #20): url in spec was a substring test, so a repository URL matched every longer repository name, and a consumer that does not pin the library was tested instead of skipped. _names_url() now requires the URL to end at the end of the spec, or at @ # / ? ; or whitespace, with or without .git. The issue's list was widened with ?, ; and whitespace so that a marker after a bare URL is still recognised.
• Docs: the save_compat.py docstring, the README scenario row, the consumers paragraph and the "not in a tag yet" row were updated.

No assertion name changes. gates/common.py and the workflows are untouched.

Closes #18
Closes #20

Verification status: gate run UNVERIFIED

A real gate run was not obtained, so this PR is not to be merged automatically. The dispatch's permission allow-list required approval for python3.12, for env-prefixed gate commands and for gh workflow run, and no approver was present. python on this host is 2.7 and python3 is 3.8. These blocks were not worked around.

The following evidence was obtained:

• python3 -m unittest tests/test_save_compat_view.py tests/test_consumers_find_pin.py tests/test_save_compat_migrations.py tests/test_result.py on 3.8: 43 tests, OK, 4 skipped (tomllib needs 3.11+). tests/test_tests_gate_probe.py cannot be imported on 3.8, with or without this change.
• Revert-and-run, gates/consumers_gate.py at origin/main: test_a_url_that_only_starts_with_the_repository_is_not_a_pin failed on all 4 lines; restored, it passed.
• Revert-and-run, gates/save_compat.py at origin/main: test_a_clean_read_with_a_warning_after_it_passes failed with (1, None, ...) != (0, {'saves': []}, ...), and test_a_scenario_that_printed_no_object_fails failed; restored, both passed.
• Check workflow (3.12, full unit suite) on the PR head.
• Real gates/save_compat.py run, PASS/FAIL lines to be quoted. No PASS or FAIL line from a real gate run exists yet.
• Real gates/consumers_gate.py run, PASS/FAIL lines to be quoted.

Suggested runs on this branch, on 3.12:

REPOSITORY=Stephenson-Software/tak SHA=640ef68e3c990e3c146731c4c4be5694d81f44de BASELINE_REF=v0.2.0 \
  SCENARIO=scenarios/tak_slots.py DISTRIBUTION=tak WORK=/tmp/prg-work python3.12 gates/save_compat.py
REPOSITORY=Stephenson-Software/tak SHA=640ef68e3c990e3c146731c4c4be5694d81f44de \
  CONSUMERS=Stephenson-Software/Tidewater WORK=/tmp/prg-consumers python3.12 gates/consumers_gate.py

Known limit

A stderr line that is itself a JSON object, such as a structured log record, is still read as the view, because run() joins both streams. Separating them means changing gates/common.py, which is outside this PR.

Issues not taken this cycle

• installed_commit reads a stderr line as the commit, failing candidate-install on a correct install #19 was deferred: its fix is in gates/common.py, which is on the do-not-auto-merge list, and the issue asks for it to be kept apart.
• Gates can pass having checked nothing: every consumer skipped, or saves with no files #21 was deferred: the issue asks the owner to choose between a new input and an unconditional failure.

This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).

---

drafted by Claude on behalf of Daniel Stephenson

🤖 Generated with Claude Code

[dmccoystephenson]

Self-review rubric, scored against commit c756a52. Result: not ready for merge. Gate-run evidence is missing.

• CI + local gate run: FAIL (UNVERIFIED) — the Check workflow passed on 3.12 (compile and the full unit suite, including tests/test_tests_gate_probe.py, which 3.8 cannot import). No real gate run was obtained, because python3.12, env-prefixed gate commands and gh workflow run all required an approval that this dispatch could not receive.
• Gate-run evidence: FAIL — no PASS/FAIL line from a real save_compat.py or consumers_gate.py run exists. Both scripts are touched, so this blocks merge. The unit tests call view() and find_pin() directly and do not stand in for a run against a real candidate.
• Scope: PASS — the 5 files changed all serve Save-compat: stderr after a scenario's JSON line fails the read as a verdict on the candidate #18 or Consumers gate: a repository URL matches any longer repository name as a pin #20; git diff --stat shows 128 insertions and 10 deletions, of which 95 lines are tests.
• Tests-new: PASS — parse_view() and _names_url() are covered by tests/test_save_compat_view.py and tests/test_consumers_find_pin.py.
• Tests-fix: PASS — checkout-revert-and-run on Python 3.8 confirmed FAIL then PASS for both fixes, with git status --porcelain confirming each revert. Consumers gate: a repository URL matches any longer repository name as a pin #20: 4 of 4 longer-name lines failed. Save-compat: stderr after a scenario's JSON line fails the read as a verdict on the candidate #18: test_a_clean_read_with_a_warning_after_it_passes and test_a_scenario_that_printed_no_object_fails failed.
• Tests-mutation: N/A — no Stage B characterization tests were added.
• Sibling structure: PASS — the new test file follows tests/test_save_compat_migrations.py (docstring, sys.path insert, unittest.TestCase).
• Sibling renames: N/A — nothing was renamed.
• Docs: PASS — the Phase 7 table was checked. Corrected in this PR: README scenario row, consumers paragraph, "not in a tag yet" row, save_compat.py docstring. No change was needed for input tables, assertion lists, result.json shape, workflow header comments or CLAUDE.md.
• Visuals: N/A — nothing a README image depicts was changed.
• Issue resolution: PASS — view() (Save-compat: stderr after a scenario's JSON line fails the read as a verdict on the candidate #18) and _names_library() (Consumers gate: a repository URL matches any longer repository name as a pin #20) are the changed surfaces. Note that Save-compat: stderr after a scenario's JSON line fails the read as a verdict on the candidate #18's request that a non-object view "must still fail" went beyond preserving behaviour: the old view() accepted a list, and it is rejected now.
• Input parity: N/A — no workflow was touched.
• Read-only: PASS — git grep -n "secrets\." .github/workflows is empty and no workflow changed.
• Stdlib only: PASS — the only new import in gates/ is typing.Optional.
• No tag moved: PASS — git ls-remote --tags origin still shows v1 to v5 and the tak/ and roam/ tags; no tag was pushed.

Judgment calls for a reviewer:

• gates/save_compat.py parse_view() — a stderr line that is itself a JSON object is read as the view. Where baseline and candidate both emit it, read-* compares two log records and passes; read-3 still fails in that case because the save count is wrong, but the fixture reads have no such backstop. Passing over stderr fully needs common.run() to keep the streams apart, which also underlies installed_commit reads a stderr line as the commit, failing candidate-install on a correct install #19.
• gates/consumers_gate.py _names_url() — ?, ; and whitespace were added to the boundary list suggested in Consumers gate: a repository URL matches any longer repository name as a pin #20.

Phase 8: the merge was withheld. The dispatch's merge pre-authorization conveys permission, not validation. The two runs listed in the PR body, on 3.12, are the remaining step.

This comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).

---

drafted by Claude on behalf of Daniel Stephenson