Repository navigation
Promote 'verify each Closes #N' to template Phase 4 - #26
Merged
Merged
Conversation
Closes #23 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dmccoystephenson
left a comment
Member
Author
There was a problem hiding this comment.
Self-review rubric:
- Scope: PASS — single 2-line addition to
create-dev-loop.mdPhase 4; no unrelated changes (see diff). - Tests-new: PASS — the new step is exercised by
gh issue view 23run during this very cycle to confirm issue body matches PR scope; no new placeholder, so no substitution-table test needed. - Tests-fix: N/A — not a bug fix.
- Sibling structure: PASS — Phase 4 already opens with prose before its bash block (cf. lines 209+ rubric intro); the new step matches that pattern.
- Sibling renames: N/A — no identifiers renamed.
- Docs: PASS — Phase 7 doc sources-of-truth table (
create-dev-loop.md,README.md) reviewed: README describes only what/create-dev-loopproduces, not the inside of the generated template, so no README change needed. - Issue resolution: PASS — issue #23 AC was 'Phase 4 has an explicit Closes #N verification step' + 'Step 4 substitution table unchanged'; both met.
- Validation: PASS — manual validation (no unresolved
{{placeholders}}introduced; no fenced code block in the addition; phase numbering unchanged) ran inline before push. - Placeholder-consistency: PASS —
grep -oP '\{\{[A-Z_]+\}\}'count unchanged after the edit (verified during validation). - Escaping: PASS — the added step is prose-only; no triple-backtick fenced block introduced inside the template.
All items PASS; one adversarial probe (could the step's position be inside 'PR body must include' instead?) was considered but rejected — the issue spec lists both placements as acceptable and 'before pushing' reads more naturally at the top of the phase.
This was referenced May 25, 2026
dmccoystephenson
added a commit
that referenced
this pull request
Aug 3, 2026
Closes #23 Co-authored-by: BuildTools <unconfigured@null.spigotmc.org> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a universal pre-push step to Phase 4 of the generated dev-loop template: before pushing, run
gh issue view <N>for everyCloses #Nto confirm the issue title/body matches the PR's actual work. Numbers carried forward from earlier session context or summarized cycles are a known source of wrong-issue auto-closes — connected to RESEARCH.md §4 (context rot in long-horizon runs).The pattern was first encoded in
example-a-dev-loop; this promotion makes it universal across all newly generated dev-loop skills.Closes #23
Test plan
{{placeholders}}introduced; substitution table unchangedRetrofit PRs against
example-l-dev-loop,example-q-dev-loop,example-a-dev-loop(canonical reword), andexample-h-dev-loopare tracked separately per the promotion-with-retrofit checklist in CLAUDE.md.drafted by Claude on behalf of Daniel Stephenson