Repository navigation
List identity, test guidance, and self-review rubric in README's generated skill structure - #167
Merged
Conversation
…rated skill structure Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (anchored on CI run 40049988646,
Judgment note: Summary: this is a docs-only drift fix. CI is green and no blocking findings were raised. This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A Stage A documentation sweep was run:
README.md,SECURITY.md,CONTRIBUTING.md,.github/PULL_REQUEST_TEMPLATE.md,.github/ISSUE_TEMPLATE/*.md, andscripts/README.mdwere each checked againstcreate-dev-loop.md. Two gaps were found inREADME.md, and both are fixed here.IDENTITY,TEST_GUIDANCE, andSELF_REVIEW_RUBRICfrom the target repo (create-dev-loop.md:620,:637,:640), and the template uses them at:131,:286, and:381–384. The README did not mention any of them.SECURITY.mdalready namesSELF_REVIEW_RUBRICas content shaped by the target repo, so the README undersold what a generated skill actually encodes. Bullets for all three have been added.README.md, formatter configs, documentation sources, the PR template, and recent commits are now included (create-dev-loop.md:58–96), which also matchesSECURITY.md's trust-model list.The other swept docs showed no drift.
CLAUDE.mdwas not edited: it is harness-blocked, and its known drift is tracked in #106.No tracking issue: the gap was found during triage.
Skipped issues: every other open issue (#106, #109, #114, #120–#125, #127, #129–#131, #133, #135, #140–#150, #158, #165) was deferred. Each one either changes template behavior, which cannot be validated headlessly per #109 and so could not merge this run, or requires editing
CLAUDE.md(#106). Per RESEARCH.md §2's tiebreaker, a documentation fix was preferred. One finding was noted: #123 and #142 are partly addressed already by the "Standing merge authorization does not satisfy the anchor gate" paragraph (create-dev-loop.md:498, from PR #119). That paragraph says a flag passed before the PR existed does not satisfy the codeowner exception, but it is framed around the UNVERIFIED case and has no Edge cases entry. The issues are left open for that remaining work.Doc sync check
README.md's "What it does" Step list still matchescreate-dev-loop.md's Steps 1:1 (no Step was added or removed;check_docs.pypasses)Test plan
python3 scripts/check_docs.py→Doc consistency check passed.python3 -m unittest discover -s tests -v→Ran 41 tests ... OKcreate-dev-loop.mdwas not touched, so no/create-dev-loopbehavioral run applies (UNVERIFIED-not-applicable).This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson