Repository navigation
Add extract_template_body edge cases and main() tests - #159
Merged
dmccoystephenson merged 1 commit intoOct 18, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (posted as a plain comment; the review was performed inline during this headless run):
Judgment call noted, not blocking: This comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
dmccoystephenson
deleted the
feature/test-extract-template-body-and-main
branch
October 18, 2026 07:18
This was referenced Oct 18, 2026
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage B (unit-test expansion) cycle — characterization tests for the two parts of
scripts/check_docs.pywith the thinnest coverage. No production code is changed.extract_template_body(previously happy path + two missing-fence errors only): six new cases covering\``bash`, the form the real template uses) not closing the template body```bash) not closing the body```not closing the body (closing fence must be exactly```at column 0)strip()ped before comparison, unlike the closing line```markdownfence winning when there are severalmain()(previously untested): newMainTestsclass, withREPO_ROOT/TEMPLATE_FILE/README_FILEpointed at a temp directory and restored intearDownAll assertions describe current behavior. None of the cases turned up a bug that needs a fix.
No tracking issue — gap found during triage.
Deferred backlog: every other open issue was left for a later cycle. Most of them (#123–#158, labeled
template-rule) change the generated-skill template. Their only behavioral anchor is a real/create-dev-looprun, which would create a GitHub repo and write outside the checkout, so a headless dispatch cannot verify or auto-merge them. The other open issues (#106, #109, #114, #128, #133, #135, #141–#143) would need eitherCLAUDE.mdedits, which the harness blocks, or decisions about process/design that a maintainer should make.Doc sync check
Not applicable — only
tests/test_check_docs.pychanged.Test plan
python3 -m unittest discover -s tests -v—Ran 41 tests ... OKlocally (32 before this PR, 9 added)python3 scripts/check_docs.py—Doc consistency check passed.doc-consistencygreen on the PR headThis PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson