Skip to content

Drop the site-count words from the COMPILE_CMD and LINT_CMD rows - #153

Merged
dmccoystephenson merged 1 commit into
mainfrom
fix/step4-site-count-wording
Oct 3, 2026
Merged

dmccoystephenson merged 1 commit into
mainfrom
fix/step4-site-count-wording

Conversation

@dmccoystephenson

Copy link
Copy Markdown
Member

Summary

  • The Step 4 COMPILE_CMD and LINT_CMD rows are reworded to drop the count words ("both places", "in both") and instead say "everywhere {{COMPILE_CMD}} appears" / "everywhere {{LINT_CMD}} appears", matching the form the TEST_CMD row took in Enumerate all three TEST_CMD substitution sites in the Step 4 row #151. This is option 1 from the issue.
  • Both rows were accurate today: the template body has exactly two occurrences of each token (lines 289/580 and 291/582 — the Phase 3 verify block and the Phase 8 rebase fence). The change removes the stated number so a future PR adding a third site does not leave the row contradicting the template, which is how the TEST_CMD row drifted after Require unique scratch filenames and define the structurally-red-anchor path #121.
  • Option 2 (a mechanical <!-- sites: N --> check in scripts/check_docs.py) was not taken: it introduces a new table convention that is a maintainer decision, and scripts/check_docs.py is on this loop's do-not-auto-merge list. The parenthetical site lists can still go stale; only option 2 would catch that class.

Closes #152

Research grounding

No RESEARCH.md finding applies. This is a documentation-accuracy rewording with no empirical claim behind it, as the issue itself states.

Doc sync check

  • Every {{placeholder}} added or changed has a corresponding Step 4 substitution-table row — no placeholders were added or removed; python3 scripts/check_docs.py passes.

README.md is unaffected (no Step added, removed, or renamed). No finding is shipped, so no RESEARCH.md entry is needed.

Test plan

  • python3 scripts/check_docs.py — "Doc consistency check passed."
  • python3 -m unittest discover -s tests — Ran 13 tests, OK
  • Occurrence counts of {{COMPILE_CMD}} and {{LINT_CMD}} in the template body re-confirmed (two each)
  • /create-dev-loop behavioral run — not performed. The change edits Step 4 instruction prose only; no template-body text, placeholder, or Step 3/5/6 path is touched, and the instruction's meaning for the current template is unchanged. The behavioral half is UNVERIFIED in the ordinary sense for this repo.

Skipped issues (recorded per Phase 1)

This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).

🤖 Generated with Claude Code


drafted by Claude on behalf of Daniel Stephenson

Closes #152

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dmccoystephenson

Copy link
Copy Markdown
Member Author

Self-review rubric (Phase 4, performed inline — no independent reviewer was available in this headless dispatch; Copilot reviewer request failed with "Could not resolve user with login 'copilot'"):

  • Scope: PASS — one file, two table rows in Step 4 (create-dev-loop.md:624, :626); no other hunks.
  • Tests-new: PASS (n/a) — no function added or changed.
  • Tests-fix: PASS (n/a) — no behavior changed. Both rows were accurate before the change (two occurrences each of {{COMPILE_CMD}} and {{LINT_CMD}} in the template body, at lines 289/580 and 291/582); only the count words were removed, so no FAIL→PASS experiment exists to run.
  • Sibling structure: PASS — no new files.
  • Sibling renames: PASS — the two sibling rows are reworded together, in the same form the TEST_CMD row took in Enumerate all three TEST_CMD substitution sites in the Step 4 row #151.
  • Docs: PASS — a repo-wide search for "both places" / "in both" finds no remaining restatement in README, CONTRIBUTING, or the GitHub templates.
  • Issue resolution: PASS — Step 4's COMPILE_CMD and LINT_CMD rows state a site count in prose that nothing checks #152's option 1 is fully implemented; option 2 is explicitly declined in the PR body with its reason.
  • CI: PASS — doc-consistency green on the PR head.
  • Placeholder parity: PASS — check_docs.py reports "Doc consistency check passed."; no placeholder added or removed.
  • README Step parity: PASS (n/a) — no Step changed.
  • Fence escaping: PASS (n/a) — no fence added.
  • Phase numbering: PASS — no phase renumbered.
  • Version comments: PASS (n/a) — header untouched.
  • Research grounding: PASS — PR body states that no finding applies.
  • No back-ported specifics: PASS — no repo-specific command, name, or prefix added.
  • gardener interface: PASS (n/a) — Steps 3/5/6 untouched.
  • Retrofit note: PASS (n/a) — no rule promoted; generated skills receive identical text.
  • Behavioral validation: UNVERIFIED — no /create-dev-loop run was performed. The edit is to Step 4 instruction prose whose meaning for the current template is unchanged, so the risk is judged low.

Out-of-diff observation: the parenthetical site lists in all three rows (COMPILE_CMD, TEST_CMD, LINT_CMD) can still go stale when a site is added; only the mechanical check in #152's option 2 would catch that class.

This review comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).


drafted by Claude on behalf of Daniel Stephenson

@dmccoystephenson

Copy link
Copy Markdown
Member Author

Merge-readiness status:

  • doc-consistency is green on the PR head. Locally, python3 scripts/check_docs.py reports "Doc consistency check passed." and python3 -m unittest discover -s tests ran 13 tests, OK.
  • Do-not-auto-merge paths: none matched. Only create-dev-loop.md changed (Step 4 prose), and Steps 3/5/6 were not touched.

The PR is left open, not merged, the same way #151 was. The change edits create-dev-loop.md's Steps. For that kind of change, the Behavioral-validation rubric item needs either a named /create-dev-loop run, or UNVERIFIED plus no auto-merge. A headless session cannot do that run, because Step 6 creates a GitHub repo and Steps 3/5 write outside the checkout. #109 tracks this structural gap. A maintainer merge should be low-risk: generated skills receive the same text as before for the current template.

This comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).


drafted by Claude on behalf of Daniel Stephenson

@dmccoystephenson
dmccoystephenson merged commit d4e32e3 into main Oct 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Step 4's COMPILE_CMD and LINT_CMD rows state a site count in prose that nothing checks

1 participant