Repository navigation
Reframe self-review as rubric-based and CI-grounded - #15
Merged
Merged
Conversation
Replaces the free-form Phase 4 self-review with an objective yes/no rubric anchored on the CI signal, adversarially framed, and explicitly capped at one intrinsic-critique pass per PR. Phase 6 now distinguishes internal critique (capped) from external signals (uncapped). Adds a SELF_REVIEW_RUBRIC placeholder so generated skills can append repo-specific rubric items, and an edge-case entry for CI failures on the PR. Motivation: empirical findings in RESEARCH.md sections 1 and 5. LLM self-critique without an external grounding signal is neutral-to-harmful (Huang ICLR 2024, Kamoi TACL 2024); rubric items are vulnerable to self-preference bias unless phrased objectively (arXiv:2604.06996); reflection iterations plateau by round 2. Template-only change. Per CLAUDE.md's promotion rule, existing child skills (dpm-dev-loop, herald-dev-loop, acsf-dev-loop) need retrofit PRs in their respective repos as follow-up. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 25, 2026
Closed
dmccoystephenson
added a commit
that referenced
this pull request
Aug 3, 2026
Replaces the free-form Phase 4 self-review with an objective yes/no rubric anchored on the CI signal, adversarially framed, and explicitly capped at one intrinsic-critique pass per PR. Phase 6 now distinguishes internal critique (capped) from external signals (uncapped). Adds a SELF_REVIEW_RUBRIC placeholder so generated skills can append repo-specific rubric items, and an edge-case entry for CI failures on the PR. Motivation: empirical findings in RESEARCH.md sections 1 and 5. LLM self-critique without an external grounding signal is neutral-to-harmful (Huang ICLR 2024, Kamoi TACL 2024); rubric items are vulnerable to self-preference bias unless phrased objectively (arXiv:2604.06996); reflection iterations plateau by round 2. Template-only change. Per CLAUDE.md's promotion rule, existing child skills (a-private-repo-1, a-private-repo-2, acsf-dev-loop) need retrofit PRs in their respective repos as follow-up. Co-authored-by: BuildTools <unconfigured@null.spigotmc.org> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SELF_REVIEW_RUBRICplaceholder so generated skills can append repo-specific objective rubric items.Motivation (per
RESEARCH.md)Per the new convention in
CLAUDE.md, design changes cite the empirical basis:The previous flow already implicitly ran self-review once (linear phases, no loop back to Phase 4), so the cap is more of a documentation/intent change than a behavioral one — but making it explicit prevents future drift and gives the agent a principled reason to refuse re-critiquing.
Retrofit follow-up
Per
CLAUDE.md's "Promoting a rule into the template" rule, this template change needs retrofit PRs in existing child skills so they don't silently lag:dmccoystephenson/example-l-dev-loopdmccoystephenson/example-q-dev-loopdmccoystephenson/example-a-dev-loopNot included in this PR — those are separate repos. Will follow up after this merges (or can be assigned).
Test plan
{{placeholder}}tokens still have rows in the Step 4 substitution table (verified:SELF_REVIEW_RUBRICadded){{#if SELF_REVIEW_RUBRIC}}...{{/if}}matches the pattern used by other optional placeholders (CODE_PATTERNS,LINT_CMD,REVIEWER,CLAUDE_MD)/create-dev-loopis run against a real repo with and without repo-specific rubric items🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson