Repository navigation
Align generated template with conventions; promote universal carry-overs - #11
Merged
Merged
Conversation
- Phase 9 generates a numbered structure with duplicate-check on step 1 (#9) - Step 4 substitution-table preamble notes it covers {{#if FLAG}} conditionals too (#10) - Phase 3 gains universal "match sibling structure" + "rename siblings together" rules (promoted from kingdom-first-era-dev-loop#1 and #2 — they're not KFE-specific) - Edge cases gain a flaky-test entry (promoted from dpm-dev-loop#12 — every tests-running loop will hit this eventually) Closes #9 Closes #10 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
dmccoystephenson
left a comment
Member
Author
There was a problem hiding this comment.
Self-review: found one bug, fixed in 0ff1aea — the new gh issue create block in Phase 9 used \ (double backslash) for line continuations instead of the single \ used everywhere else in the file. Would have rendered as literal \ in the generated skill and broken shell parsing. No other issues found on a second pass over the diff.
The new gh issue create block in the generated Phase 9 used \\ (double backslash) for line continuations, which would render as literal \\ in the generated skill and break the command in shell. Match the convention used by every other line continuation in this file (single \).
dmccoystephenson
added a commit
that referenced
this pull request
Aug 3, 2026
…ers (#11) * Align generated template with conventions; promote universal carry-overs - Phase 9 generates a numbered structure with duplicate-check on step 1 (#9) - Step 4 substitution-table preamble notes it covers {{#if FLAG}} conditionals too (#10) - Phase 3 gains universal "match sibling structure" + "rename siblings together" rules (promoted from kingdom-first-era-dev-loop#1 and #2 — they're not KFE-specific) - Edge cases gain a flaky-test entry (promoted from a-private-repo-1#12 — every tests-running loop will hit this eventually) Closes #9 Closes #10 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Self-review fix: use single \ for line continuations in Phase 9 template The new gh issue create block in the generated Phase 9 used \\ (double backslash) for line continuations, which would render as literal \\ in the generated skill and break the command in shell. Match the convention used by every other line continuation in this file (single \). --------- Co-authored-by: BuildTools <unconfigured@null.spigotmc.org> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{{#if FLAG}}conditionals too (closes Step 4 substitution table should note it covers {{#if FLAG}} conditionals too #10)This is the first PR in a series bringing all dev-loop skills into line with the conventions just codified in example-skills-catalog/CONVENTIONS.md. Subsequent PRs against
example-h-dev-loop,example-k-dev-loop,kingdom-first-era-dev-loop, andexample-a-dev-loopwill retrofit the same Phase 9 structure into existing generated skills.Test plan
create-dev-loop.mdPhase 3, Phase 9, Step 4, and Edge cases sections{{CODE_PATTERNS}}substitutionCloses #9
Closes #10
drafted by Claude on behalf of Daniel Stephenson