Skip to content
This repository was archived by the owner on Aug 12, 2025. It is now read-only.

Optional proxy - #11

Merged
StanDeMan merged 2 commits into
StanDeMan:mainfrom
Daniel127:feature/optional-proxy
Jul 13, 2022
Merged

StanDeMan merged 2 commits into
StanDeMan:mainfrom
Daniel127:feature/optional-proxy

Conversation

@Daniel127

Copy link
Copy Markdown

Hi @StanDeMan

I have seen your last changes and I found them very good, but I could not start the application without the proxy so I have added a new property so you can change it easily and when you want.

imagen

I have also updated the WebApp with the Net 6 template.

Regarding the properties obtained from the launchSettings I have changed to get everything from the profile with the project name and if necessary from IIS Express, but I think it is not good to mix properties from different profiles.

If you want to have the IIS Express profile for debugging in windows I think it is fine but should not modify the configuration parameters of Kestrel, ideally you could use the profile settings with the same name of the Debugger Target but I do not know how to do it, so you could even have different configurations for Kestrel or IIS if desired.

imagen

Let me know if you are ok with these changes

@Daniel127 Daniel127 changed the title Feature/optional proxy Optional proxy Jul 12, 2022
@StanDeMan

StanDeMan commented Jul 12, 2022 •

Copy link
Copy Markdown
Owner

Hi Daniel127,

yah, this looks promising. With this change both worlds are first class citizens. ;)
Let me check in deep, but I think I can take your pull request and integrate it. Thanks a lot. This should work quite better.

Give me one day to check. If I have some questions - I'll ask. :)
Great! Thanks again.

Kindest regards
StanDeMan

@StanDeMan
StanDeMan merged commit 744fbc3 into StanDeMan:main Jul 13, 2022
@StanDeMan

Copy link
Copy Markdown
Owner

Hi Daniel127,

seems to work as desired.
Maybe it needs some more information about the usage in the dialog box? Will also adapt the instructions for use accordingly.

Kindest regards
StanDeMan

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants