This repository was archived by the owner on Apr 13, 2023. It is now read-only.
Repository navigation
Feature/Webpack & Container 2.0 - #76
Merged
Merged
Conversation
chipbell4
suggested changes
Oct 1, 2019
chipbell4
left a comment
chipbell4
left a comment
Contributor
There was a problem hiding this comment.
Need to update the container integration to use the new syntax for adding plugins
Comment on lines
+23
to
+38
| container.uses(new UserDataPlugin()); | ||
| container.uses(new HelpPlugin('#helpButton')); | ||
| container.uses(captions); | ||
| container.uses(new PausePlugin('#pauseButton, #resumeButton')); | ||
| container.uses( | ||
| new SoundPlugin({ | ||
| voButton: '#voButton', | ||
| soundButton: '#soundButton', | ||
| sfxButton: '#sfxButton', | ||
| musicButton: '#musicButton', | ||
| voSlider: '#voiceRange', | ||
| musicSlider: '#musicRange', | ||
| sfxSlider: '#sfxRange', | ||
| soundSlider: '#mainVolume' | ||
| }) | ||
| ); |
Contributor
There was a problem hiding this comment.
Looks like the uses function is no longer available on the SpringRollContainer. You'll have to switch to the new syntax:
new springroll.Container('selector', {
plugins: [...]
});| query: queryArgs.length ? '?' + queryArgs.join('&') : '' | ||
| }) | ||
| .catch(err => err.json()) | ||
| .then(({ error }) => alert(error)); |
Contributor
There was a problem hiding this comment.
This isn't great, but it's better than the old "Invalid API" message 👎
Ideally this sort of permissions check could happen at page load in JS (but that's out of scope for this PR)
Contributor
|
Tests are passing locally with no problems. The failing builds seem to be related to Travis' mongo and chrome version. I'm going to go ahead and merge since we'll be migrating to Github actions soon. |
902seanryan
pushed a commit
that referenced
this pull request
Nov 7, 2019
Feature/Webpack & Container 2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.