Repository navigation
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Critical and moderate issues remain in the enable/disable pool handling.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Fixes gameset toggling so hidden consumables stay synchronized with the legendary pool.
Changes:
- Removes hidden consumables when disabled.
- Restores them when re-enabled.
| File | Summary |
|---|---|
lib/gameset.lua |
Synchronizes hidden consumables with the legendary pool; pool references still require correction. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| SMODS.Center.enable(self) | ||
| SMODS.insert_pool(G.P_CENTER_POOLS["Consumeables"], self) | ||
| if self.hidden then | ||
| table.insert(self.legendaries, self) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Disabling Cryptid's Spectral set removes White Hole from
G.P_CENTERS, but leaves it inSMODS.Consumable.legendaries. A Celestial Pack can still rollc_cry_white_hole, causingcreate_cardto index a nil center.Remove hidden consumables from the legendary pool when disabling them and restore them when re-enabling them, matching Steamodded's hidden-consumable injection/deletion behavior. The existing disabled-state guards prevent duplicate entries on repeated enable calls.
Validation:
git diff --checkpass.