Repository navigation
Fix uninitialized SimMap state causing crashes with simd - #43
Open
GuillaumeDelorme wants to merge 1 commit into
Open
GuillaumeDelorme wants to merge 1 commit into
GuillaumeDelorme wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SimMap was allocated with malloc but only fd and addr were initialized. The uninitialized hasSimApiDat flag could cause simapi_init() to skip shared-memory setup. With simd running, the subsequent simapi_datamap() call then attempted to copy from a null address, causing SIGSEGV.
Initialize the entire structure, handle allocation failure, and check initialization errors before reading telemetry. The public API remains unchanged.
I reproduced the crash with LMU using my Rust binding (https://github.com/GuillaumeDelorme/simapi-rs). It don't crash anymore if i rebuild simd with this fix.