Skip to content

Fix building with node 10.0.0 - #71

Open
Paxa wants to merge 15 commits into
Southern:masterfrom
stormwin:master
Open

Paxa wants to merge 15 commits into
Southern:masterfrom
stormwin:master

Conversation

@Paxa

@Paxa Paxa commented Jul 7, 2018

Copy link
Copy Markdown

I found this useful patch in #68 (i'm not an author of this changes)

Thank you @stormwin

@stormwin

stormwin commented Jul 8, 2018 •

Copy link
Copy Markdown

If i have more free time, i will fix backward incompatibilities with older nodejs versions. The problem is with OpenSSL version that is changed from 1.0.x to 1.1.x in nodeJS v10.x

@stormwin

stormwin commented Jul 8, 2018

Copy link
Copy Markdown

OK, finally it work on every nodejs version.

@Paxa

Paxa commented Jul 9, 2018

Copy link
Copy Markdown
Author

Bravo!

@jacobpdq

Copy link
Copy Markdown

@Southern bump plz (needed for node-solid)

@alexanderkhivrych

Copy link
Copy Markdown

plz merge it

@alexanderkhivrych

Copy link
Copy Markdown

ASAP

@alexanderkhivrych

alexanderkhivrych commented Jul 19, 2018 •

Copy link
Copy Markdown

build already green

@alexanderkhivrych

Copy link
Copy Markdown

@stormwin

@stormwin

Copy link
Copy Markdown

I am also waiting for this merge. Till then, i am using my own fork in my projects

@jacobpdq

jacobpdq commented Jul 19, 2018 via email

Copy link
Copy Markdown

@alexanderkhivrych

Copy link
Copy Markdown

@Southern

@Paxa

Paxa commented Jul 23, 2018

Copy link
Copy Markdown
Author

Guys, you can just use it from github: yarn add stormwin/node-x509 or npm i stormwin/node-x509

@Paxa

Paxa commented Jul 28, 2018

Copy link
Copy Markdown
Author

@yorkie I just created a PR from @stormwin fork

@eduardocruz

Copy link
Copy Markdown

Did the project die?

@adamhamlin

Copy link
Copy Markdown

Bump

@mbwhite

mbwhite commented Nov 16, 2018

Copy link
Copy Markdown
Contributor

Can this be merged please?

@stormwin

Copy link
Copy Markdown

OK, i will try to fix this styling stuffs and also will try to fix some warnings for node v11. Will do a new commits today or tomorrow

@ghost

ghost commented Nov 23, 2018

Copy link
Copy Markdown

@stormwin you awesome!
thanks for fixing this,
hoping to see it merged

@okonon

okonon commented Nov 30, 2018

Copy link
Copy Markdown

Bump. @stormwin any chance that you fixed that styling ?

@okonon

okonon commented Jan 11, 2019

Copy link
Copy Markdown

Anyone can resolve the conflicts?

@prompt-bot

Copy link
Copy Markdown

there any follow up?

@mbwhite

mbwhite commented Mar 17, 2019

Copy link
Copy Markdown
Contributor

there any follow up?

We would have preferred to use this repo - but due to schedules we had to fork and republished to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants