Skip to content

fix bug for https://github.com/RubaXa/Sortable/issues/628 #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
why520crazy wants to merge 1 commit into from
Closed

fix bug for https://github.com/RubaXa/Sortable/issues/628 #741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions Sortable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@
}
})(function () {
"use strict";

if (typeof window == "undefined" || typeof window.document == "undefined") {
return function() {
throw new Error( "Sortable.js requires a window with a document" );
}
return function () {
throw new Error("Sortable.js requires a window with a document");
};
}

var dragEl,
Expand Down Expand Up @@ -334,8 +334,11 @@
// we can re-enable the events: touchmove/mousemove
_this._disableDelayedDrag();

// Make the element draggable
dragEl.draggable = true;
// fix bug for https://github.com/RubaXa/Sortable/issues/628
if (_this.nativeDraggable) {

@RubaXa RubaXa Jan 20, 2016

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just dragEl.draggable = _this.nativeDraggable.

// Make the element draggable
dragEl.draggable = true;
}

// Chosen item
_toggleClass(dragEl, _this.options.chosenClass, true);
Expand Down Expand Up @@ -818,7 +821,7 @@
this._nulling();
},

_nulling: function() {
_nulling: function () {
// Nulling
rootEl =
dragEl =
Expand Down