Repository navigation
knockout-sortable - prioritise global dependencies if available - #737
Merged
Merged
Conversation
…ck to require / AMD
Collaborator
|
@srosengren Code Review? |
Contributor
|
I like the idea since I've had this usecase myself in some projects. Code looks good. Merge. |
Collaborator
|
👌 |
RubaXa
added a commit
that referenced
this pull request
Jan 18, 2016
knockout-sortable - prioritise global dependencies if available
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the dependency resolution logic of knockout-sortable.js to first look for knockout / Sortable global references, before trying require and AMD. This allows the script to be used in a require / AMD environment but still allowing knockout (and/or Sortable) to be referenced globally.
Use Case
It can be advantageous, even when in a browserify / requireJS / AMD environment, to include separate scripts to a public CDN for popular libraries, like knockout in order to take advantage of cross-site caching of these libraries. In this case, large dependencies like knockout do not need to increase the size of a generated JS build (in the case of browserify) or cause additional http requests (in the case of AMD / requireJS).