You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[bug] Sortable swapping does not work when forceFallback is enabled and a handle or content is a custom element (web component) with a shadowRoot #2346
With this line target = target.shadowRoot.elementFromPoint(touchEvt.clientX, touchEvt.clientY);, its returning elements within our handle custom element or content custom element instead of a child of the Sortable instance.
This only happens when in forceFallback: true or when used by a mobile device which seems to always go into fallback mode.
When using native drag and drop the issue is not seen.
Activity
fix: set the target as the host element when target contains a shadow…
fix: fix dragging items on a mobile device (#8751)
fix: fix dragging items on a mobile device (#8751)
owen-m1 commentedon Mar 22, 2024
Thank you, PR has been merged
driskull commentedon Mar 22, 2024
Thank you @owen-m1 🍻
jcfranco commentedon Apr 5, 2024
Thanks, @driskull and @owen-m1! When is the next SortableJS release planned?
driskull commentedon Jun 17, 2024
@owen-m1 any chance we can get a new release with this fix?
fix: set the correct Sortable parent when within a shadowRoot (#9532)
owen-m1 commentedon Sep 1, 2024
Thank you @driskull it has been released in 1.15.3
[Snyk] Upgrade sortablejs from 1.15.0 to 1.15.3 (#5)
[Snyk] Upgrade sortablejs from 1.15.3 to 1.15.6 (#11)