Repository navigation
support the general access dialog section - #341
Merged
Merged
Conversation
Prompt: tests were added by ai, multiple prompts Co-authored-by: GPT-5.4 Mini <gpt-5.4-mini@openai.com>
SharonStrats
requested review from
timea-solid
and
a balanced review from Copilot
October 9, 2026 07:26
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Two test fixtures use an incorrect AuthenticatedAgent IRI and should match the production ACL subject.
2 open findings
What changed in this PR
Adds ACL APIs needed by the general access dialog.
Changes:
- Exposes public/authenticated subjects and public access roles.
- Adds public-role/mode mappings and API tests.
- Updates test doubles and package version.
| File | Description |
|---|---|
src/acl/aclLogic.ts |
Implements and exposes public ACL roles and subjects. |
src/types.ts |
Extends the public ACL interface. |
src/index.ts |
Exports the new ACL API. |
test/publicAclApi.test.ts |
Verifies exports, mappings, and types. |
test/resourceLogic.test.ts |
Updates the ACL test double. |
test/resource/resourceLogic.test.ts |
Updates the resource ACL fixture. |
package.json |
Bumps the package version. |
package-lock.json |
Synchronizes the package version. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
timea-solid
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support the general access dialog section for public and authenticated agents.