Skip to content

Fix npm crawler oracle flake from symlink-cycle trees #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mikola Lysenko (mikolalysenko) merged 1 commit into from
Oct 2, 2026
Merged

Fix npm crawler oracle flake from symlink-cycle trees #582

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions crates/socket-patch-core/src/crawlers/npm_crawler/oracle.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1336,12 +1336,18 @@ mod tests {
let _ = std::fs::write(entry.join("node_modules"), "file");
}
76..=79 => {
// An entry whose node_modules is a symlink.
if let Some(target) = self.nm_dirs.first().cloned() {
let entry = store.join(self.store_entry_name(&name, &version));
let _ = std::fs::create_dir_all(&entry);
Self::symlink(&target, &entry.join("node_modules"));
}
// An entry whose node_modules is a symlink (to a
// dir outside the tree, so the followed walk cannot
// cycle: a link back to an ancestor `node_modules`
// is walked until the OS refuses the path, which
// compares where two walkers gave up, not what
// they found).
let entry = store.join(self.store_entry_name(&name, &version));
let _ = std::fs::create_dir_all(&entry);
let id = self.uniq();
let elsewhere = self.scratch.join(format!("pnpm-nm{id}"));
self.package_json(&elsewhere.join(&name), &name, &version);
Self::symlink(&elsewhere, &entry.join("node_modules"));
}
80..=83 => {
// The entry itself is a symlink (skipped).
Expand Down
Loading