Repository navigation
Fix uv pylock wiring wheels under no-binary (#1603) - #1672
Mikola Lysenko (mikolalysenko) merged 7 commits into
Conversation
Assisted-by: Claude Code:claude-opus-5-5
A PEP 751 lock from `uv pip compile --no-binary six` records six with
only its sdist, and `uv pip` installs six only from an sdist under that
flag or a uv `no-binary` setting. Both scan modes still swapped in the
patched wheel and exited 0, so the matching `uv pip sync` then failed
("marked as `--no-binary` but is itself a binary distribution").
Hosted and vendored scans now refuse such a lock before writing
anything when the `uv pip compile` command line in its header passes
`--no-binary` naming the package or `:all:`, or the root's uv.toml /
`[tool.uv]` covers it through `[pip] no-binary`, `no-binary = true` or
`no-binary-package`. Checked against uv 0.11.32: `[pip]` and top-level
settings add up, and `no-binary = false` turns off only the top-level
package list. Locks written by other tools are left alone.
Fixes #1603
Assisted-by: Claude Code:claude-opus-5-5
Review follow-ups for the pylock no-binary refusal: - uv takes `uv pip`'s settings from the nearest parent directory when the project root sets none, so a parent `uv.toml` or `[tool.uv]` with `no-binary` now refuses too, as it already does for uv projects and scripts. - Pipenv installs the pylocks it reads and ignores uv settings, so those locks keep Pipenv's own refusal (hosted) or are wired as before (vendored) instead of getting a uv error. - `--no-binary :none:` clears the earlier values, as in uv, so a lock compiled with `--no-binary :all: --no-binary :none:` is not refused. The restore side now reads the flag the same way. - The root settings are read once per run instead of once per lock. Refs #1603 Assisted-by: Claude Code:claude-opus-5-5
|
BugBot review Generated by Claude Code |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Autofix Details
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed:
--no-configskips install settings- Removed the early return that skipped project settings checks when --no-config was present, since uv pip sync still applies those settings even when compile used --no-config.
Or push these changes by commenting:
@cursor push cecfabd11a
Preview (cecfabd11a)
diff --git a/crates/socket-patch-core/src/patch/redirect/mod.rs b/crates/socket-patch-core/src/patch/redirect/mod.rs
--- a/crates/socket-patch-core/src/patch/redirect/mod.rs
+++ b/crates/socket-patch-core/src/patch/redirect/mod.rs
@@ -26365,6 +26365,8 @@
),
// `:none:` clears only the values before it.
(" --no-binary :none: --no-binary six", &[]),
+ // `uv pip compile --no-config` skips settings, but sync still applies them.
+ (" --no-config", &[("uv.toml", "no-binary = true\n")]),
];
for (flags, extra) in refusals {
let result = run(flags, extra);
@@ -26393,10 +26395,8 @@
warning.detail
);
}
- // Another package's flag or setting, no-build, a list turned off by
- // no-binary = false, a uv.toml replacing pyproject's settings, and
- // settings `uv pip compile --no-config` never read leave the wheel
- // installable.
+ // Another package's flag or setting, no-build, or a list turned off by
+ // no-binary = false leave the wheel installable.
let wired: &[(&str, &[(&str, &str)])] = &[
("", &[]),
(" --no-binary idna", &[]),
@@ -26419,7 +26419,6 @@
),
],
),
- (" --no-config", &[("uv.toml", "no-binary = true\n")]),
(" --no-binary :all: --no-binary :none:", &[]),
// The root's own settings stop the lookup above it.
(
diff --git a/crates/socket-patch-core/src/patch/redirect/upstream/uv.rs b/crates/socket-patch-core/src/patch/redirect/upstream/uv.rs
--- a/crates/socket-patch-core/src/patch/redirect/upstream/uv.rs
+++ b/crates/socket-patch-core/src/patch/redirect/upstream/uv.rs
@@ -737,9 +737,6 @@
"the lock's `uv pip compile --no-binary` covers {name}, {consequence}"
));
}
- if command.contains(&"--no-config") {
- return None;
- }
}
let (path, key) = settings_no_binary(settings, &name)?;
Some(format!(
diff --git a/crates/socket-patch-core/src/vendor/pypi_lock.rs b/crates/socket-patch-core/src/vendor/pypi_lock.rs
--- a/crates/socket-patch-core/src/vendor/pypi_lock.rs
+++ b/crates/socket-patch-core/src/vendor/pypi_lock.rs
@@ -1789,6 +1789,8 @@
pyproject("[tool.uv]\nno-binary-package = [\"two\"]\n"),
)),
),
+ // `uv pip compile --no-config` skips settings, but sync still applies them.
+ (" --no-config", Some(("uv.toml", "no-binary = true\n"))),
] {
let Err(error) = load(pylock(flags), config).await else {
panic!("{flags:?} with {config:?} must refuse");
@@ -1797,10 +1799,8 @@
assert!(error.1.starts_with("pylock.toml: "), "{}", error.1);
assert!(error.1.contains("only from an sdist"), "{}", error.1);
}
- // Another package's flag or setting, no-build, a list turned off by
- // no-binary = false, a uv.toml that replaces pyproject's settings,
- // and settings `uv pip compile --no-config` never read leave the
- // wheel installable.
+ // Another package's flag or setting, no-build, or a list turned off by
+ // no-binary = false leave the wheel installable.
for (flags, config) in [
("", None),
(" --no-binary six", None),
@@ -1813,7 +1813,6 @@
"no-binary = false\nno-binary-package = [\"two\"]\n",
)),
),
- (" --no-config", Some(("uv.toml", "no-binary = true\n"))),
(" --no-binary :all: --no-binary :none:", None),
] {
if let Err(error) = load(pylock(flags), config).await {You can send follow-ups to the cloud agent here.
The uv pylock restore test made its hosted lock by running the hosted rewrite on a lock already under `--no-binary`. That rewrite now refuses such a lock, so the test wires the plain lock first and then adds the flag or setting. That is how such a lock reaches the restore in real use: it was wired before this check existed, or filtered later. Refs #1603 Assisted-by: Claude Code:claude-opus-5-5
|
BugBot review Generated by Claude Code |
`uv pip compile --no-config` only keeps settings files away from the compile. The later `uv pip sync` still reads uv.toml, so a `no-binary` setting there still makes it refuse the patched wheel. The pylock check now reads the settings whatever the header says. Refs #1603 Assisted-by: Claude Code:claude-opus-5-5
|
BugBot review Generated by Claude Code |
Mikola Lysenko (mikolalysenko)
added
the
Ready for review
|
Ready for review at Generated by Claude Code |
Final review briefWhat it does. Before it writes a patched wheel into a uv-made PEP 751 pylock, socket-patch now checks whether uv would refuse to install that wheel, and refuses first (finishes #1603). It refuses in two cases:
Hosted mode marks the patch refused with Risk: low. The change only adds refusals; it never writes anything new.
Look here
Verified
Changes I made: none. Open questions (not blocking)
Auto-merge (squash) is armed, so approving sends it straight to the merge queue. Generated by Claude Code |
uv reads `[pip] no-binary = [":all:", ":none:"]` in order, the same way it reads repeated `--no-binary` flags: `:none:` clears the values before it, so `uv pip sync` installs the patched wheel (checked with uv 0.11.32). The pylock check treated any `:all:` in the list as covering the package and refused a lock that would install fine. Both the list and the header flags now go through one ordered reader. Refs #1603 Assisted-by: Claude Code:claude-opus-5-5
|
BugBot review Generated by Claude Code |
|
[agent] Fixed the open question from the final review brief in 6ef706e. With uv 0.11.32, Generated by Claude Code |
In a uv workspace member, `uv pip` reads the workspace root's settings and never the member's own `[tool.uv]`, so a root-level no-binary setting would break a member pylock that the no-binary check reads from the member. Both modes already refuse a run in a governed member before reading any lock (#1138), so that pylock is never wired. This test pins that. Refs #1603 Assisted-by: Claude Code:claude-opus-5-5
|
BugBot review Generated by Claude Code |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 02faef7. Configure here.
|
[final reviewer] Turned auto-merge off. My last brief covered Generated by Claude Code |
Final review brief (head
|
|
Still Ready for review at the new head (burn-down agent). The earlier label comment covered
Generated by Claude Code |
LLM Description written by Claude Code:claude-opus-5-5
Fixes #1603
This finishes #1603. #1649 fixed the uv project,
uv.tomland PEP 723 script lanes and saidRefs, leaving the PEP 751 lane from the issue's follow-up comment. That lane was waiting on #1614, which has now merged.Root cause
uv installs a package only from an sdist when it falls under
--no-binary, and every Socket artifact is a wheel.uv pip compile --no-binary six --format pylock.tomlrecords six with only its sdist. Both scan modes still replaced that entry with the patched wheel and exited 0. After that, the matchinguv pip syncfailed with "marked as--no-binarybut is itself a binary distribution". Nothing at wire time read the two places this filter can come from:uv pip compilecommand line recorded in the lock header, and#1614 already reads both of these, but only on the hosted restore side.
Fix
upstream::uv::pylock_no_binaryis shared by both modes and refuses before any write. It only looks at a lock withcreated-by = "uv", and refuses when either:uv pip compilepasses--no-binarynaming the package or:all:. As in uv,:none:clears the values given before it.[pip] no-binary, a top-levelno-binary = true, orno-binary-package. This applies even when the header shows--no-config, because that flag only kept settings away from the compile anduv pip syncstill reads them (Bugbot finding, fixed in db67fc0).The settings it reads are the root's
uv.toml, else pyproject's[tool.uv], else the nearest parent settings file. That is the same lookup #1501/#1545 use, carried by the existingUV_ANCESTOR_CONFIG_KEY.Checked against real uv 0.11.32 with a lock that has only the wheel:
[pip]and top-level settings add up rather than one replacing the other.no-binary = falseturns off only the top-level package list.:none:clears the earlier values.What each mode does:
redirect_uv_lock_unsupported, and the engine now also reads the rootuv.tomland the parent settings when a pylock is present.pypi_uv_no_binary, the same code Fix uv scans wiring wheels under no-binary (#1603) #1649 uses.Pylocks that Pipenv installs (
wire_pipenv_pylocks/pipenv_reads_pylock) are not checked, because Pipenv reads no uv setting. A user- or system-leveluv.tomlis not read, for the same reason #1649 gave: it belongs to the machine that installs.docs/testing/uv-compatibility.mdis updated.Tests (red → green)
:all:,[pip]/top-level/pyproject settings, parent settings;--no-config+ settings; controls incl.:none:, Pipenv, non-uv lock)patch::redirect::python_lock_warning_tests::pylock_no_binary_refuses_a_wheel_uv_would_not_installuv.toml, Pipenv path)vendor::pypi_lock::tests::pylock_no_binary_refuses_before_writingmode_migration_pypi::uv_pylock_no_binary_is_refused_in_both_modes"Without fix" means the check was short-circuited to
None.Local runs (Linux, uv 0.11.32):
cargo fmt --all -- --checkandcargo clippy --workspace --all-features -- -D warnings: clean.cargo test -p socket-patch-core -p socket-patch-cli --all-features --lib: CLI 925 ok. Core 6641 ok and 4 failed. The 4 are permission-injection tests (copy_treerelax_loop,vlt_healunremovable lock, poetry/requirements wire-write failure) that can't fail when run as root, which this sandbox is. This change doesn't touch them.--test mode_migration_pypi: 68 ok.--test e2e_redirect_uv_build --include-ignored: 23 ok.--test e2e_vendor_pypi_build --include-ignored: 55 ok.cargo test --workspaceran out of the sandbox's disk allowance while building every integration binary, so CI covers the rest.CI follow-up
On a33ca5e,
coveragefailed inupstream_restore_golden::pip_compile_pylock_build_filters_refuse_the_filtered_entry. That test built its hosted lock by running the hosted rewrite on a--no-binarylock, which the rewrite now refuses. It now wires the plain lock first and then adds the flag or setting, which is how such a lock reaches the restore in real use. All 31 core integration binaries pass locally (0656163)./code-review high
Fixed:
:none:was ignored--no-binaryparsing (now onebinary_flag_covers, also used by the restore side)Not changed:
uv pip sync, and the uv project lane from Fix uv scans wiring wheels under no-binary (#1603) #1649 behaves the same way (pypi_uv_no_binaryis not supersedable).https://claude.ai/code/session_015NdfJ6nfxCRsW1FVjrkuPm
Generated by Claude Code