CI: repair suite asserts codes, not sentences (#1089)

[Mikola Lysenko (mikolalysenko)]

LLM Description written by Claude Code:claude-opus-5-5

Refs #1089 (child 2, repair slice)

Problem

The repair suite's covgap files pin English sentences in --json
mode (e["error"].contains("no manifest record for patch"), …) and
keep private parse_env/events_of envelope readers, so a copy edit
to a repair message breaks them even when the exit code, error code,
events and bytes on disk are unchanged.

Change (test-only)

• repair/covgap_commands_repair_vendor.rs → repair/repair_vendor_failure_paths.rs:
  reads envelopes through common::envelope; asserts errorCodes,
  events and disk state. A message is read only for a token it must
  name (a flag, a uuid, state.json), or, where several arms share
  one code, the short phrase that says which arm fired. Those phrases
  live in named constants (ARM_MOVED_ON, ARM_STALE_UUID,
  ARM_BAD_IDENTITY) so they can go once the arms get codes of their own.
• repair/covgap_commands_repair.rs → repair/repair_render.rs, the
  repair render suite (human output, sentence checks kept); its one
  --json leg moves onto common::envelope.
• repair/coverage_fix_repair_vendor_predelete.rs → repair/repair_vendor_predelete.rs
  on common::envelope.
• repair/repair_vendor_e2e.rs, repair/repair_vendor_flavors_e2e.rs
  and repair_vendor_flavors_e2e/vlt.rs drop their private readers for
  common::envelope, so no repair file needs a ratchet exemption.
• Ratchet: parse_env/events_of join the private-reader names, with
  positive and negative self-test cases.
  apply/in_process_gem_fallback_home.rs (the apply suite, not this
  slice) defines a parse_env and is listed as pending.

covgap_commands_vendor.rs (the rest of child 2) stays for a later slice.

Test evidence

• cargo test -p socket-patch-cli --all-features --test repair: 129/129
  pass as a non-root user. As root, two chmod-based tests
  (repair_cleanup_failure_is_reported_in_json_and_silent_modes,
  repair_exits_zero_and_stays_quiet_when_lock_file_unremovable) fail
  because root ignores the read-only dir; neither is changed here and
  both pass non-root.
• cargo test … --test cli envelope: 16/16 pass (ratchet + self-tests).
• cargo fmt --all -- --check, cargo clippy --locked --workspace --all-features -- -D warnings, cargo check --locked --workspace --all-targets --all-features: clean.

Code review (/code-review high)

Fixed: arm discrimination for the shared vendor_uuid_mismatch /
vendor_artifact_unrepairable codes (4 findings), the two repair
files left on private readers, untested ratchet names, the dropped
render-suite blob summary check, the weakened diff label check, and
a stale module doc.
Not fixed here: repair_invariants.rs still reads one --json
message ("mutually exclusive"); it was outside the covgap files this
slice moves and goes with the next #1089 slice.

CI cost

Test-only, no workflow changes. A lean PR run keeps the same job count
and minutes (about 28 Linux jobs, ~8 min wall), before and after.

🤖 Generated with Claude Code

https://claude.ai/code/session_01KPaZwe1urf5BTu41J38V4N

---

Generated by Claude Code

[Mikola Lysenko (mikolalysenko)]

BugBot review

---

Generated by Claude Code

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 4eae757. Configure here.}