Repository navigation
Follow the republished minimist canary patch - #1302
Closed
Mikola Lysenko (mikolalysenko) wants to merge 2 commits into
Closed
Mikola Lysenko (mikolalysenko) wants to merge 2 commits into
Mikola Lysenko (mikolalysenko) wants to merge 2 commits into
Conversation
Production withdrew the minimist@1.2.2 patch 80630680-… on 2026-10-09 and republished it as 642d7f02-… with a new patched index.js (afterHash ec956dca…). Every live-API suite that pins the old UUID or hash failed: hosted-e2e, e2e_safety_pnpm and the Bun and vlt compatibility matrices, which turned main and every PR red. Point the production-facing tests, backtest harnesses and the Bun compatibility doc at the new patch. Offline shape tests and binary fixtures keep the old UUID; they never reach the service. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Mikola Lysenko (mikolalysenko)
enabled auto-merge
October 9, 2026 16:40
This was referenced Oct 9, 2026
Mikola Lysenko (mikolalysenko)
pushed a commit
that referenced
this pull request
Oct 9, 2026
Port of #1302 (fixes #1293). Production withdrew the free minimist@1.2.2 patch 80630680-… and republished the same fix as 642d7f02-…, with a new patched index.js (afterHash ec956dca…). That turned hosted-e2e and e2e_safety_pnpm red on main and here. No-ops once main carries #1302 or #1301. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Mzbk9WDZkhatFrCWUAyaNs
This was referenced Oct 9, 2026
The republished minimist patch records its files as `index.js` and `test/proto.js` instead of `package/index.js`. The vlt backtest stripped the first path segment unconditionally, so every cell errored with IndexError before checking any installed bytes. Strip the `package/` prefix only when present, as the Bun harness does. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Oct 9, 2026
Mikola Lysenko (mikolalysenko)
pushed a commit
that referenced
this pull request
Oct 9, 2026
The republished minimist patch (642d7f02) keys its files without the
package/ prefix, so key.split('/', 1)[1] raised IndexError in every
native vlt leg. Ports the matching line from #1302.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YRcjmQwhWGod7X58Hbe5FW
This was referenced Oct 9, 2026
Tanmay Singla (Tanmay182003)
approved these changes
Oct 9, 2026
This was referenced Oct 9, 2026
Mikola Lysenko (mikolalysenko)
removed this pull request from the merge queue due to a manual request
Oct 9, 2026
Collaborator
Author
|
Superseded by #1301, which merged the same repin to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1293
Production withdrew the canary patch for
pkg:npm/minimist@1.2.2(80630680-4da6-45f9-bba8-b888e0ffd58cnow answerswithdrawnfrom/patch/package, andPatch not foundfrom/patch/view). It republished the fix at 2026-10-09 15:57Z as642d7f02-ebc1-4ab0-99e2-07f5dd8463cb, with a new patchedindex.js(afterHashec956dca…, previously043f04d1…) and an addedtest/proto.js.Main's run 37954539425 (CI), 37954539418 (Bun) and 37954539561 (vlt) failed because of this, which blocks every PR in the merge queue:
hosted-e2e: hosted proofs rewrote nothing ("production publishes no patches").e2e_safety_pnpm:index.jshash did not match the oldafterHash.patch 80630680-… is not granted: 'withdrawn'.Change
The UUID and
afterHashare updated in the production-facing tests (e2e_hosted_production,e2e_vendored_production,e2e_safety_pnpm,e2e_npm), inscripts/backtest-bun.pyandscripts/backtest-vlt.py, and indocs/testing/bun-compatibility.md. Offline UUID-shape tests, wiremock suites and binary.lockb/golden fixtures keep the old UUID, because they never contact the service.Verified locally
cargo test -p socket-patch-cli --test e2e_hosted_production -- --include-ignored: 65 passed.--test e2e_safety_pnpm: 23 passed.python3 -m unittest discover -s scripts/tests: 296 OK.backtest-vlt.fetch_grant()returns the new tarball and its sha512.Two existing failures are unrelated to this change, and neither suite is in the PR gate:
e2e_npmtest_npm_uuid_shortcutandtest_npm_global_lifecycle: the shortcut now runs hosted mode in a lockfile project.e2e_vendored_productionyarn_berry_vendored_install_proof: no manifest is written.🤖 Generated with Claude Code
Note
Low Risk
Test and documentation constant updates only; no runtime or security-sensitive application code is modified.
Overview
Production withdrew the free-tier minimist@1.2.2 canary patch and republished the same CVE fix under a new UUID, with updated patched
index.jsbytes. This PR retargets every production-facing pin so hosted/vendored e2e, npm/pnpm safety tests, Bun/vlt backtest scripts, and Bun compatibility docs use642d7f02-ebc1-4ab0-99e2-07f5dd8463cband the newafterHash(ec956dca…).No CLI or patch-application logic changes—only constants and comments that gate CI against the live public proxy.
Reviewed by Cursor Bugbot for commit 84570cc. Configure here.