Skip to content

Scope the project-mode cargo crawl to the crates Cargo.lock resolves (#1204) #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mikola Lysenko (mikolalysenko) merged 5 commits into from
Oct 9, 2026
Merged

Scope the project-mode cargo crawl to the crates Cargo.lock resolves (#1204) #1205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1befaea
Start refactor for #1204
claude Oct 9, 2026
6c0077f
Share one Cargo.lock registry-source predicate
claude Oct 9, 2026
7dc0fe1
Scope project-mode cargo crawl to Cargo.lock
claude Oct 9, 2026
3baf9cc
Name the registry check is_from_registry
claude Oct 9, 2026
4cb55a9
Vouch for the GC crate through vendor/, not cache
claude Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions crates/socket-patch-cli/tests/scan/scan_ecosystems_scope_e2e.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,21 +212,16 @@ async fn gc_scan_keeps_the_unscoped_lockfile_only_count() {
}
}

/// The crawl of a GC run itself is unscoped: a crate installed under
/// `CARGO_HOME` (and absent from `Cargo.lock`, so only the cargo CRAWL can
/// vouch for it) keeps its manifest entry under `-e npm --prune`, while an
/// uninstalled npm entry is still prunable.
/// The crawl of a GC run itself is unscoped: a crate installed in the
/// project's `vendor/` tree (and absent from `Cargo.lock`, so only the
/// cargo CRAWL can vouch for it; a locked project's registry cache is only
/// looked up for its locked crates) keeps its manifest entry under
/// `-e npm --prune`, while an uninstalled npm entry is still prunable.
#[tokio::test]
async fn gc_scan_crawls_the_unselected_ecosystems() {
let tmp = tempfile::tempdir().unwrap();
stage_project(tmp.path());
let krate = tmp
.path()
.join(".cargo-home")
.join("registry")
.join("src")
.join("index.crates.io-6f17d22bba15001f")
.join(format!("{INSTALLED_CRATE}-0.2.0"));
let krate = tmp.path().join("vendor").join(INSTALLED_CRATE);
std::fs::create_dir_all(&krate).unwrap();
std::fs::write(
krate.join("Cargo.toml"),
Expand Down
Loading
Loading