Follow-up from #1046 (audit B69/test hygiene).
The generalized passed > 0 guard in the ci.yml e2e step (ci.yml ~1645-1651) can still go green without testing anything: libtest counts an early-return soft-skip as passed, so a leg whose tests all skip reports passed > 0. Only per-suite *_REQUIRED env gates catch this, and not every row sets one (e.g. e2e_redirect_rush_sim).
Options:
- have the non-vlt e2e step grep a standard skip marker, as
check-vlt-legs.py does for the vlt step; or
- give every e2e row a
*_REQUIRED gate.
🤖 Generated with Claude Code
Follow-up from #1046 (audit B69/test hygiene).
The generalized
passed > 0guard in the ci.yml e2e step (ci.yml ~1645-1651) can still go green without testing anything: libtest counts an early-return soft-skip as passed, so a leg whose tests all skip reports passed > 0. Only per-suite*_REQUIREDenv gates catch this, and not every row sets one (e.g.e2e_redirect_rush_sim).Options:
check-vlt-legs.pydoes for the vlt step; or*_REQUIREDgate.🤖 Generated with Claude Code