Repository navigation
Conversation
The published nupkgs carried no license information, so dependency scanners report them as unlicensed. Add upstream HtmlParserSharp's LICENSE.txt (consolidating the per-file MIT notices the code already carries), embed licenses in both packages, and bump patch versions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
HtmlParserSharpandCsQuerynupkgs ship with no license metadata, so dependency scanners flag them as unlicensed (e.g. in services using PfgFramework).Fix
source/HtmlParserSharp/LICENSE.txt, copied verbatim from upstream. It gathers the MIT/WHATWG notices that our source files already carry in their headers, so no new terms are introduced.PackageLicenseFileand pack the license into both packages; CsQuery uses the existing root MITLICENSE.txt.RepositoryUrl, plus authors and a description for HtmlParserSharp.2.0.1, CsQuery3.0.1.Checked locally with
dotnet pack: both nuspecs now contain<license type="file">and includeLICENSE.txt.Notes
dotnet pack source/HtmlParserSharp(as the Jenkinsfile runs it) fails locally with MSB5004 (duplicate project names in the.sln). This is pre-existing and not touched here.🤖 Generated with Claude Code