Repository navigation
Conversation
DERSignature.stream_serialize does not write the remaining length of the message after the header byte. This patch resolves the issue by writing the length of what remains to be written immediately after the header byte.
Author
|
Why not use self.length ? it is already calculated and set in stream_deserialize() |
Author
|
closing for now. this conversation is better done at the original pull request at python-bitcoinlib: petertodd#190 |
Author
|
Note that this is now not relevant for python-bitcointx - this code is replaced with a calls to libsecp256k1 functions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DERSignature.stream_serialize does not write the remaining length of the message after the header byte.
This patch resolves the issue by writing the length of what remains to be written immediately after the header byte.
originally submitted by @m4burns to petertodd#190