Which fork should I use? #17

Activity

1. dgpv commented on Dec 11, 2018

   

   dgpv

   on Dec 11, 2018

   Last edited by dgpv

   More actions

   This is based on https://github.com/petertodd/python-bitcoinlib

   https://github.com/dgpv/python-bitcoinlib is just temporary clone of petertodd's repo with some additional patches, that was used before python-bitcointx was created. https://github.com/dgpv/python-bitcoinlib will not be maintained.

   I cannot advise you on what you should use. It is up to you. You may create your own fork and maintain it, if you wish.

   👍React with 👍1Reacted by Dan B
2. dbolser commented on Dec 11, 2018

   

   dbolser

   on Dec 11, 2018

   Author

   More actions

   Right, I understand. Thanks for carrying this forward. I think the ideal situation would be for you to get co-maintainer status on the 'central' repo, or for the central repo to point (with a caveat) to your fork.

   Thanks again,
   Dan.
3. dgpv commented on Dec 11, 2018

   

   dgpv

   on Dec 11, 2018

   Last edited by dgpv

   More actions

   The thing here is that this is not a fork. This is derivative library.

   It is not directly compatible - I deliberately changed the module name to 'bitcointx'.

   I removed all the network-related code, because:

   • It is not relevant for our product (https://simplexum.com)
   • We are not ready to expend resources to maintain the code that we do not use

   We are also not concerned with python2 compatibility, so I made this library python3-only.

   If someone wants the original library with the new functionality that is present in python-bitcointx, they are free to take our code and apply to their python-bitcoinlib fork.
4. dbolser commented on Dec 11, 2018

   

   dbolser

   on Dec 11, 2018

   Author

   More actions

   OIC, interesting.
5. dgpv

   closed this as completedon Dec 11, 2018