Skip to content

Support customising the external eye and new EyeStyles - #307

Open
IggsGrey wants to merge 5 commits into
SimpleSoftwareIO:developfrom
IggsGrey:rounded_external_eye
Open

IggsGrey wants to merge 5 commits into
SimpleSoftwareIO:developfrom
IggsGrey:rounded_external_eye

Conversation

@IggsGrey

@IggsGrey IggsGrey commented Aug 9, 2024

Copy link
Copy Markdown

No description provided.

@Jamalofski

Copy link
Copy Markdown

Thanks for this PR. The rounded and pointy eyes and the separate external and internal styles shipped in jamalofski/simple-qrcode 4.4.0, a maintained fork of this package, with you as co-author. One change: eye() still styles the whole eye, and externalEye() and internalEye() override the ring or the center, so existing code renders as before; externalEye('circle') draws a round ring. Background in #332.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants