Skip to content

Update Generator.php - #291

Open
DonCamillo11 wants to merge 1 commit into
SimpleSoftwareIO:developfrom
DonCamillo11:develop
Open

DonCamillo11 wants to merge 1 commit into
SimpleSoftwareIO:developfrom
DonCamillo11:develop

Conversation

@DonCamillo11

@DonCamillo11 DonCamillo11 commented Sep 21, 2023 •

Copy link
Copy Markdown

Style $size must be between 0 (exclusive) and 1 (inclusive) according to class RoundnessModule from Bacon/BaconQRCode

Style $size must be between 0 (exclusive) and 1 (inclusive)
@Jamalofski

Copy link
Copy Markdown

Thanks for this PR. The fix shipped in jamalofski/simple-qrcode 4.5.0, a maintained fork of this package, with you as co-author: style() takes a size of 1 and rejects 0 for dot and round, as bacon expects. style('square', 0) is still accepted, since the square style ignores the size. Background in #332.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants