Skip to content

Ruby 3 support - #53

Merged
larouxn merged 2 commits into
masterfrom
ruby_3_support
Jan 14, 2021
Merged

larouxn merged 2 commits into
masterfrom
ruby_3_support

Conversation

@larouxn

@larouxn larouxn commented Jan 9, 2021

Copy link
Copy Markdown
Contributor

Add support and CI testing for Ruby 3.0.0 by removing Ruby ~> 2.4 requirement and updating CI config.

https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/

@larouxn larouxn self-assigned this Jan 9, 2021
Comment thread Gemfile
@@ -1,4 +1,4 @@
ruby '~> 2.4'
ruby '>= 2.4'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we want to keep this ruby '~> 2.4' but if we do I think we need >= to support Ruby 2 and 3.
Screen Shot 2021-01-10 at 18 06 59

@larouxn
larouxn force-pushed the replace_travis_with_github_actions branch from fa5f004 to 71f8bc4 Compare January 14, 2021 05:55
@larouxn
larouxn force-pushed the ruby_3_support branch 4 times, most recently from 94f8939 to f9aad86 Compare January 14, 2021 06:05
@larouxn larouxn mentioned this pull request Jan 14, 2021
Base automatically changed from replace_travis_with_github_actions to master January 14, 2021 06:15
@larouxn
larouxn merged commit 90625fa into master Jan 14, 2021
@larouxn
larouxn deleted the ruby_3_support branch January 14, 2021 06:29
larouxn added a commit that referenced this pull request Jan 14, 2021
@larouxn larouxn mentioned this pull request Jan 14, 2021
@larouxn
larouxn deployed to production January 15, 2021 01:46 Active
sjahu pushed a commit that referenced this pull request Oct 6, 2026
Every CI run since December 2024 fails before tests start, in the job
labelled "Ruby 3". Two things combined:

1. The matrix lists Ruby versions as unquoted YAML numbers (#53, 2021).
   YAML reads 3.0 as the number 3, so setup-ruby installs the latest
   3.x, not Ruby 3.0. Harmless until 3.x meant 3.4.
2. Gemfile.lock pins Bundler 2.2.33 (7cb1151, June 2024), whose vendored
   Thor references DidYouMean::SPELL_CHECKERS. Ruby 3.4 ships
   did_you_mean 2.0.0, which removed that constant, so Bundler 2.2.33
   crashes on load under Ruby 3.4.

setup-ruby v1.206.0 (2024-12-26) added Ruby 3.4.0. From then on "3"
meant 3.4, Bundler 2.2.33 crashed, and fail-fast cancelled the other
jobs, so no Ruby reported a result.

Changes: quote the matrix versions; add Ruby 3.4; fail-fast: false;
bump the Bundler pin to 2.4.22 (newest that installs on Ruby 2.7 and
loads on 3.4); actions/checkout v2 -> v4.

Verified locally: Bundler 2.2.33 reproduces the CI NameError on Ruby
3.4.9; with 2.4.22 the suite passes on Ruby 3.4.9 and 4.0.7.

This branch was successfully deployed

1 active deployment
production — 5d298f2e Deployed Jan 15, 2021 by larouxn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants