[Security] Stop logging the app logs subscription token - #8750
Draft
github-actions[bot] wants to merge 1 commit into
Draft
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
The app logs subscription JWT was written verbatim to debug output, so it landed in any `--verbose` session a developer might share when reporting an issue. The adjacent debug line already confirms the subscription succeeded, so the token itself carries no diagnostic value. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Subscribing to app logs returns a JWT that acts as a bearer credential for that app's log stream. It was written verbatim to debug output, so it was captured by any
--verbosesession — exactly the output developers routinely paste into issue reports and support threads. This is a sensitive-data-in-logs issue in the app logs subscription path.The debug line immediately below already reports that the subscription succeeded, so the token value itself carried no diagnostic information.
WHAT is this pull request doing?
Removes the debug line that printed the subscription token in
packages/app/src/cli/services/app-logs/utils.ts. The surrounding debug output (API key, subscribed shop IDs, success flag) is unchanged, and the token is still returned to callers exactly as before, soapp devandapp logsbehave identically.Adds a focused regression test asserting the token never appears in debug output.
How to manually test your changes?
Log streaming works as before, and the verbose output no longer contains the subscription token.
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add