Skip to content

Implement Payment model #37

Open
Open
Implement Payment model#37
Labels
GrantFox OSSIssue tracked in GrantFox OSSMaybe RewardedIssue may be eligible for a GrantFox rewardThird CampaignCampaign: Third Campaignarea:modelspriority:p1type:feature

Description

@codebestia
codebestia
opened on Jul 20, 2026

Represents a Shade payment resource returned by the API. All monetary amounts should be stored as Decimal to avoid floating-point precision issues.

Proposed Steps:

  • Create src/shade/models/payment.py.
  • Fields: id: str, status: str, amount: Decimal, currency: str, description: Optional[str], merchant_id: str, stellar_tx_hash: Optional[str], payment_address: str, created_at: datetime, updated_at: datetime.
  • Add a PaymentStatus StrEnum with values: pending, completed, cancelled, expired, partially_paid.
  • Validate that amount > 0.

Acceptance Criteria:

  • Payment.from_dict(api_response) constructs the model without error.
  • payment.amount is a Decimal, not a float.
  • payment.status is a PaymentStatus enum value.
  • Invalid status strings raise a clear validation error.

Activity

  1. codebestia
    added
    type:feature
    priority:p1
    area:models
    on Jul 20, 2026
  2. grantfox-oss
    added
    GrantFox OSSIssue tracked in GrantFox OSS
    Maybe RewardedIssue may be eligible for a GrantFox reward
    Official Campaign | FWC26Campaign: Official Campaign | FWC26
    on Jul 20, 2026

  3. sainath5001 commented on Jul 20, 2026

    @sainath5001
    sainath5001
    on Jul 20, 2026 – with GrantFox OSS

    Hi, I would like to work on this issue.

    I have experience implementing blockchain-related data models, payment flows, and validation logic. I’m familiar with designing strongly typed models, handling API response mappings, using Decimal for financial precision, and implementing enums with validation.

    I can implement the Payment model, PaymentStatus enum, amount validation, and ensure all acceptance criteria are covered.

  4. grantfox-oss
    assigned
    sainath5001
    on Jul 20, 2026

  5. grantfox-oss commented on Jul 20, 2026

    @grantfox-oss
    grantfox-ossBot
    on Jul 20, 2026 – with GrantFox OSS

    🦊 GrantFox — @sainath5001 has been assigned to this issue as part of the Official Campaign | FWC26 campaign!

    Next steps:

    1. Open a Pull Request referencing this issue (e.g., Closes #37)
    2. Your PR will be reviewed by the ShadeProtocol maintainers

    Good luck! Track your progress on GrantFox.

  6. codebestia
    unassigned
    sainath5001
    on Aug 3, 2026
  7. grantfox-oss
    added
    GrantFox OSSIssue tracked in GrantFox OSS
    Maybe RewardedIssue may be eligible for a GrantFox reward
    Third CampaignCampaign: Third Campaign
    and removed
    Maybe RewardedIssue may be eligible for a GrantFox reward
    GrantFox OSSIssue tracked in GrantFox OSS
    Official Campaign | FWC26Campaign: Official Campaign | FWC26
    on Aug 21, 2026

  8. guptakumarranjeet150 commented on Sep 12, 2026

    @guptakumarranjeet150
    guptakumarranjeet150
    on Sep 12, 2026

    Hello! I'd like to work on this issue.

    I would love to take this on. My planned approach:

    • Deliver a clean, modular solution for Implement Payment model strictly following ShadeProtocol/shade-python conventions.
    • Cover changes with automated tests ensuring CI passes smoothly.

    Excited to work on this—please assign to me and I'll submit a clean PR shortly!

  9. ranjeet150 commented on Sep 14, 2026

    @ranjeet150
    ranjeet150
    on Sep 14, 2026

    Hello @maintainers,

    I can tackle Implement Payment model. Proposed implementation roadmap:

    • Analysis: Inspect current behavior and edge cases in ShadeProtocol/shade-python
    • Implementation: Deliver a clean, modular solution for Implement Payment model strictly following ShadeProtocol/shade-python conventions.
    • Testing: Cover changes with automated tests ensuring CI passes smoothly.
    • PR: Atomic commit with clean git hygiene and passing CI

    Excited to work on this—please assign to me and I'll submit a clean PR shortly!

  10. rupesh-kumar-sah commented on Oct 3, 2026

    @rupesh-kumar-sah
    rupesh-kumar-sah
    on Oct 3, 2026

    Hello maintainers,

    I am interested in taking up Implement Payment model.

    Implementation approach:

    1. Inspect repository architecture in ShadeProtocol/shade-python for an idiomatic solution.
    2. Implement the feature/fix with clean modular separation and robust error handling.
    3. Add comprehensive unit and integration test coverage for all edge cases.
    4. Verify that all linters, formatting, and CI checks pass cleanly.

    Could you please assign this issue to me? Looking forward to delivering a clean PR.

  11. shobhamerabacha-star commented on Oct 3, 2026

    @shobhamerabacha-star
    shobhamerabacha-star
    on Oct 3, 2026

    Greetings,

    I would like to work on this issue.

    Proposed steps:

    1. Inspect repository architecture in ShadeProtocol/shade-python for an idiomatic solution.
    2. Implement the feature/fix with clean modular separation and robust error handling.
    3. Add comprehensive unit and integration test coverage for all edge cases.
    4. Verify that all linters, formatting, and CI checks pass cleanly.

    Please assign this to me if the plan looks good. Thanks!

  12. Rodrigoue9 commented on Oct 6, 2026

    @Rodrigoue9
    Rodrigoue9
    on Oct 6, 2026

    Hi maintainers! 👋 I would love to take on issue #37 (Implement Payment model).

    Technical Analysis & Implementation Approach (TypeScript / Web3)

    1. Architecture & Scope:
      • Audit requirements and target files cleanly without introducing regressions to existing interfaces.
      • Enforce explicit error boundaries, input sanitization, and deterministic lifecycle handling.
    2. Quality & Standard Compliance:
      • Fully satisfy all acceptance criteria for Implement Payment model following the repository's established conventions.
      • Clean linting, strict typing, and zero compiler/clippy warnings.
    3. Verification & Testing:
      • Dedicated unit and integration tests covering the happy path, boundary conditions, and failure recovery.
      • Zero-regression guarantee across existing test suites.

    Production Track Record

    • Verified Stellar & Soroban Track Record: Merged PRs in cybermax4200/stellar-did-credit #898 & #900 (+400 points Wave 9), approved review in documenso/documenso #3275, active deliveries in Vero-protocol/vero-core-contracts, Sorobill/*, and Bitcoindefi/OpenAO.

    Ready to implement and deliver as soon as officially assigned! Looking forward to contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    GrantFox OSSIssue tracked in GrantFox OSSMaybe RewardedIssue may be eligible for a GrantFox rewardThird CampaignCampaign: Third Campaignarea:modelspriority:p1type:feature

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions