Repository navigation
Improve !verify-admin and patch !issue - #387
Merged
Merged
Conversation
It's so strange how providing the right parameter to send allows slackerbot to send the right thing
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#328 called for improving the functionality of
!verify-admin. In the current state, an admin must use this parser twice to verify a user and then set their message. This PR reworks the logic used to allow this to be done in a single call.Resolves #328
This also includes a small fix to the
!issueparser to ensure rich feedback is returned on issue creation.Note on change
This change removes the prior functionality that allowed the user to toggle verification by calling
!verify-admin username. It contains a message about calling the new help method, and additionally I will ask the admins to share this knowledge internally to minimize the impact of the 'breaking' change.Usage
Examples:
Verify and update message
Remove user verification
Update message