You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add per-character handling for hidden Framer's Kit rows - #5
Characters that have not completed the relevant raid content do not see the eleven Framer's Kit rows in the Mathematics (Other) shop.
Because material purchases currently use hard-coded visible-row indices, affected characters purchase an item eleven rows later than configured.
This change:
Corrects the current material ordering.
Adds a per-character setting indicating whether the raid Framer's Kits are visible.
Preserves the existing behavior by default.
Subtracts eleven from material-shop callback rows only when the setting is disabled.
Does not affect relic purchases or other plugin behavior.
The zero-versus-eleven row discrepancy was reproduced from both shop layouts. A zero-offset fork was tested successfully by an affected user and purchased the intended item.
The integrated per-character checkbox path has not yet been tested across both layouts, so this is being submitted as a draft for review and testing.
Thanks for taking the time to look into the issue and make this PR. Didn't really think about people not doing the raid content, so they didn't unlock the additional shop items.
I think the general idea behind the system is good, although I don't really like the idea that people have to manage whether they have completed the content and potentially buy the wrong item(s) if they forget to tick a checkbox.
A better solution that would future-proof it for new expansions might be to buy items based on the Item ID instead of the hard-coded index; it would require a bit of rewriting for the tome shop system, but in turn should make it consistent regardless of new items being added.
I'll have a look at the system again to make some changes that should work for everyone. Thanks again for bringing it up tho.
The new version v0.21.0.2 should now correctly buy the item you've selected, regardless of if you've done the raid content to unlock the framer's kits or not.
Thanks again for taking the time to look at this issue, and for brining it to my attention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Characters that have not completed the relevant raid content do not see the eleven Framer's Kit rows in the Mathematics (Other) shop.
Because material purchases currently use hard-coded visible-row indices, affected characters purchase an item eleven rows later than configured.
This change:
The zero-versus-eleven row discrepancy was reproduced from both shop layouts. A zero-offset fork was tested successfully by an affected user and purchased the intended item.
The integrated per-character checkbox path has not yet been tested across both layouts, so this is being submitted as a draft for review and testing.