Skip to content

[CI] Wire contract tests + lint into CI #25

Open

Description

@Gbangbolaoluwagbemiga

Problem

CI (.github/workflows/node.yml) runs npm test --if-present, which is a no-op because no
JS tests exist, and it never invokes the Rust test runner — even though .config/nextest.toml
is already checked in. Contract regressions ship undetected.

What needs to be done

  • Add a contract job step running cargo nextest run (uses the existing nextest config)
  • Add cargo clippy --all-targets -- -D warnings
  • Add cargo fmt --all -- --check
  • Cache the cargo registry + target/ for speed (build cache block already exists — extend it)
  • Make the job a required status check on main

Acceptance criteria

  • A failing #[test] or a clippy warning fails CI
  • cargo fmt drift fails CI
  • Green run visible on a PR

Relevant files

.github/workflows/node.yml, .config/nextest.toml, Cargo.toml

References

Depends on #1 (tests must exist for the runner to be meaningful).

Activity

  1. changed the title [-]Wire contract tests + lint into CI[/-] [+][CI] Wire contract tests + lint into CI[/+] on Jun 17, 2026
  2. guptakumarranjeet150 commented on Oct 3, 2026

    @guptakumarranjeet150

    Hello team,

    I looked into [CI] Wire contract tests + lint into CI and have an implementation approach ready.

    Solution overview:

    1. Audit storage layout and state invariants ensuring strict auth guards.
    2. Implement deterministic state transitions with safe checked arithmetic.
    3. Add hermetic unit and regression tests covering authorized, unauthorized, and boundary edge cases.
    4. Profile instruction and CPU/gas limits under Soroban host environment.

    Ready to implement immediately upon assignment. Please feel free to assign!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    infraCI/CD, builds, toolingtestingTests and coverage

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions