Skip to content

Citus #3

Closed
Closed

Description

@ChakshuGautam

Every single issue should have the following

  • Precise steps on how to add the extension to the Dockerfile
  • How to enable the extension
  • Actual smoke tests described in English
  • CI Updated with smoke tests

Activity

  1. jayanth-kumar-morem commented on Apr 13, 2023

    @jayanth-kumar-morem
    Collaborator

    Hi @ChakshuGautam , I would like to take this one up, can you assign me to this

  2. added a commit that references this issue on Apr 13, 2023
    1518ee0
  3. jayanth-kumar-morem commented on Apr 13, 2023

    @jayanth-kumar-morem
    Collaborator

    Thanks @ChakshuGautam ,
    I have raised a PR #11

  4. ChakshuGautam commented on Apr 13, 2023

    @ChakshuGautam
    CollaboratorAuthor

    Hey @jayanth-kumar-morem currently Citus and Timescale are not compatible - "Another time-partitioning extension for PostgreSQL is TimescaleDB. Unfortunately, Citus and TimescaleDB are currently not compatible." from this article. Can you also add a feature to disable TimescaleDB by default so the user has a choice to add it when needed?

    Also added a checklist for this ticket. Please update the smoke tests for this addition. Thanks :)

  5. jayanth-kumar-morem commented on Apr 14, 2023

    @jayanth-kumar-morem
    Collaborator

    Hi @ChakshuGautam ,

    Could you share more details on the last point in the checklist, Build pipeline updates needed .

    Also, To provide users with the option to enable or disable TimescaleDB by default, we can make use of an environment variable to control the extension creation during the PostgreSQL initialization process. We can edit the entrypoint script for the Docker image that checks the environment variable and enables TimescaleDB accordingly. Can you confirm whether we are on the same plate on implementing this, so that I can go ahead with the coding part :)

    PR #12

  6. ChakshuGautam commented on Apr 15, 2023

    @ChakshuGautam
    CollaboratorAuthor

    Hey, @jayanth-kumar-morem the PR looks good. I have removed the Build pipeline updates needed from the checklist. I will add it as a separate ticket.

  7. jayanth-kumar-morem commented on Apr 18, 2023

    @jayanth-kumar-morem
    Collaborator

    Okay @ChakshuGautam , is there anything else we need to work on this issue before merging the code. ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions