You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey @jayanth-kumar-morem currently Citus and Timescale are not compatible - "Another time-partitioning extension for PostgreSQL is TimescaleDB. Unfortunately, Citus and TimescaleDB are currently not compatible." from this article. Can you also add a feature to disable TimescaleDB by default so the user has a choice to add it when needed?
Also added a checklist for this ticket. Please update the smoke tests for this addition. Thanks :)
Could you share more details on the last point in the checklist, Build pipeline updates needed .
Also, To provide users with the option to enable or disable TimescaleDB by default, we can make use of an environment variable to control the extension creation during the PostgreSQL initialization process. We can edit the entrypoint script for the Docker image that checks the environment variable and enables TimescaleDB accordingly. Can you confirm whether we are on the same plate on implementing this, so that I can go ahead with the coding part :)
Activity
jayanth-kumar-morem commentedon Apr 13, 2023
Hi @ChakshuGautam , I would like to take this one up, can you assign me to this
warpsql: Add support for Citus extension
jayanth-kumar-morem commentedon Apr 13, 2023
Thanks @ChakshuGautam ,
I have raised a PR #11
ChakshuGautam commentedon Apr 13, 2023
Hey @jayanth-kumar-morem currently Citus and Timescale are not compatible - "Another time-partitioning extension for PostgreSQL is TimescaleDB. Unfortunately, Citus and TimescaleDB are currently not compatible." from this article. Can you also add a feature to disable TimescaleDB by default so the user has a choice to add it when needed?
Also added a checklist for this ticket. Please update the smoke tests for this addition. Thanks :)
jayanth-kumar-morem commentedon Apr 14, 2023
Hi @ChakshuGautam ,
Could you share more details on the last point in the checklist,
Build pipeline updates needed.Also, To provide users with the option to enable or disable TimescaleDB by default, we can make use of an environment variable to control the extension creation during the PostgreSQL initialization process. We can edit the entrypoint script for the Docker image that checks the environment variable and enables TimescaleDB accordingly. Can you confirm whether we are on the same plate on implementing this, so that I can go ahead with the coding part :)
PR #12
ChakshuGautam commentedon Apr 15, 2023
Hey, @jayanth-kumar-morem the PR looks good. I have removed the
Build pipeline updates neededfrom the checklist. I will add it as a separate ticket.jayanth-kumar-morem commentedon Apr 18, 2023
Okay @ChakshuGautam , is there anything else we need to work on this issue before merging the code. ?