Skip to content

Hook player titles through the shared implementation - #337

Open
Guffawaffle wants to merge 1 commit into
STFC-Mod:devfrom
Guffawaffle:fix/chat-title-hook-window
Open

Guffawaffle wants to merge 1 commit into
STFC-Mod:devfrom
Guffawaffle:fix/chat-title-hook-window

Conversation

@Guffawaffle

Copy link
Copy Markdown
Contributor

The title bind callbacks share a small native wrapper. On Windows client 272 it occupies 16 bytes, less than SPUD's 24-byte detour window, so hooking it corrupts the adjacent title-clear callback. Upstream now skips these wrappers on Windows to prevent the crash.

Hook PlayerTitleWidget.SetIdentifiers once instead: both bind callbacks reach that substantive implementation. This retains bind-time title filtering on Windows, removes the duplicate wrapper targets, and preserves the current title-hiding behavior and macOS native-size checks.

Validation:

  • Windows client 272: verified both wrappers branch to SetIdentifiers and the new target fits the detour window.
  • Windows release build and diff checks passed. A player confirmed repeated chat opens stay stable on the settings-based build containing this hook relocation; the standalone artifact has not been deployed during that settings test.
  • macOS native fit and gameplay remain unverified on ARM64 and Intel. Test chat open/close/reopen, title hiding, row reuse and player-profile titles on each architecture before merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant