Repository navigation
Hook player titles through the shared implementation - #337
Open
Guffawaffle wants to merge 1 commit into
Open
Guffawaffle wants to merge 1 commit into
Guffawaffle wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The title bind callbacks share a small native wrapper. On Windows client 272 it occupies 16 bytes, less than SPUD's 24-byte detour window, so hooking it corrupts the adjacent title-clear callback. Upstream now skips these wrappers on Windows to prevent the crash.
Hook
PlayerTitleWidget.SetIdentifiersonce instead: both bind callbacks reach that substantive implementation. This retains bind-time title filtering on Windows, removes the duplicate wrapper targets, and preserves the current title-hiding behavior and macOS native-size checks.Validation:
SetIdentifiersand the new target fits the detour window.