You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Maven now generates a Manifest file and adds it to the JAR file. However, I'm not familiar with OSGi and hope that the limitations in regards to class loading don't affect this library. If there are any problems, please let me know!
Firstly when I run the maven build the Manifest in the resulting jar doe not seem to contain the information I supplied above.
It does look like a valid OSGi Manifest to me. Is there anything wrong with it? It's not exactly the same as the one you provided, since it's auto-generated via Maven.
When using goals (clean package) I just see following in the manifest file in the target directory jar:
Manifest-Version: 1.0
Archiver-Version: Plexus Archiver
Created-By: Apache Maven
Built-By: Garry
Build-Jdk: 1.7.0_10
@garpinc I have no experience with OSGi but from what I've read so far, every library has its own class loader and takes the separation of modules very seriously. Since java-object-diff relies heavily on reflection of external classes, I'm a little bit worried, whether this is even possible in an OSGi environment. Have you already tried using java-object-diff in your OSGi system and now if it works?
@garpinc I have no experience with OSGi but from what I've read so far, every library has its own class loader and takes the separation of modules very seriously. Since java-object-diff relies heavily on reflection of external classes, I'm a little bit worried, whether this is even possible in an OSGi environment. Have you already tried using java-object-diff in your OSGi system and now if it works?
Reply to this email directly or view it on GitHub: #53 (comment)
Activity
SQiShER commentedon Feb 16, 2013
Maven now generates a Manifest file and adds it to the JAR file. However, I'm not familiar with OSGi and hope that the limitations in regards to class loading don't affect this library. If there are any problems, please let me know!
SQiShER commentedon Feb 17, 2013
It does look like a valid OSGi Manifest to me. Is there anything wrong with it? It's not exactly the same as the one you provided, since it's auto-generated via Maven.
garpinc commentedon Feb 17, 2013
When using goals (clean package) I just see following in the manifest file in the target directory jar:
Manifest-Version: 1.0
Archiver-Version: Plexus Archiver
Created-By: Apache Maven
Built-By: Garry
Build-Jdk: 1.7.0_10
SQiShER commentedon Feb 17, 2013
Huh? When I run the same goal, I get the following Manifest:
So I guess, when I deploy it to Maven Central, it will be fine.
SQiShER commentedon Feb 24, 2013
@garpinc I have no experience with OSGi but from what I've read so far, every library has its own class loader and takes the separation of modules very seriously. Since java-object-diff relies heavily on reflection of external classes, I'm a little bit worried, whether this is even possible in an OSGi environment. Have you already tried using java-object-diff in your OSGi system and now if it works?
garpinc commentedon Feb 24, 2013
I not entirely sure how it works. I'll get specifics tomorrow. But it works great..
From: Daniel Bechlermailto:notifications@github.com
Sent: 2/24/2013 1:58 PM
To: SQiShER/java-object-diffmailto:java-object-diff@noreply.github.com
Cc: garpincmailto:garpinc@hotmail.com
Subject: Re: [java-object-diff] Make Library OSGi-compatible (#53)
@garpinc I have no experience with OSGi but from what I've read so far, every library has its own class loader and takes the separation of modules very seriously. Since java-object-diff relies heavily on reflection of external classes, I'm a little bit worried, whether this is even possible in an OSGi environment. Have you already tried using java-object-diff in your OSGi system and now if it works?
Reply to this email directly or view it on GitHub:
#53 (comment)
SQiShER commentedon Mar 4, 2013
That it works great is all I needed to know. Thanks! :-)