Repository navigation
Speed up settings edits and add Editor/Presenter slide navigation - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings edits no longer rewrite unrelated inspector fields or repeatedly reload hidden dialogs. One edit uses one window refresh and an accurate before/after audio-readiness comparison. Editor Previous/Next includes every slide; stopped Presenter navigation works even when some audio needs updating. Shared View-menu shortcuts act on the visible view.
Validation: 518 tests pass on stock Qt 6.11.2 and 518 on native Qt 6.10.2/Breeze using Xvfb and a private null sink. Native screenshots were inspected at both required window sizes. At 60 slides, inspector edits are 4.8–8.0× faster; duration, record and mode are at least 2× faster. The user approved up to two readiness passes (120 evaluations); each edit has one full refresh and no hidden-dialog loads.
Production growth is +90 lines including the benchmark, within +100. Tests add 237 net lines. Exact measurements, commands, failed attempts and evidence:
docs/reviews/2026-10-01-edit-latency-and-navigation.md.This is PR A. The separate settings draft/Preferences refactor (PR B) will be stacked on this branch.