Skip to content

Fix CI platform assumptions and Windows asset lifetime defects - #11

Merged
VolkerChristian merged 11 commits into
mainfrom
codex/ci-platform-tests
Oct 12, 2026
Merged

VolkerChristian merged 11 commits into
mainfrom
codex/ci-platform-tests

Conversation

@VolkerChristian

@VolkerChristian VolkerChristian commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

CI could hang on unexpected Qt warning dialogs and failed because backend mocks, fonts and source encodings assumed Linux. Correct the test environment so failures report their actual cause, and retain real audio integration coverage with the existing audio_device marker and an isolated local sink.

Fix two Windows application defects at their ownership boundaries: PDF reload releases playback file handles before replacing the project directory and restores audio after a failed installation; draft cancellation compares asset names using the same portable format as imports so referenced media is preserved.

Validation on the approved production change:

  • Ubuntu: 563 passed.
  • Windows: 530 passed, 33 platform skips.
  • macOS: 553 passed, 10 platform skips.
  • All three native packages and packaged-app smoke checks passed (run 38240512151). That run's documentation-index failure is corrected, and the subsequent hygiene job passes (run 38240707142).
  • Full local Qt 6.11.2 suite with private stereo audio: 577 passed, 1 PipeWire-specific skip, including all 15 audio integration cases.
  • PDF reload: 15 passed, including new success/failure handle-lifetime regressions.

Production net +2 lines, explicitly approved; tests net +59. Shared CI workflow, build manifest, application backend selection and physical audio settings remain unchanged.

See docs/reviews/2026-10-12-ci-platform-tests.md for exact commands, intermediate failures, environment limitations and accounting. Final documentation-only commit records these results; production/test trees match the verified commits.

@VolkerChristian
VolkerChristian marked this pull request as ready for review October 12, 2026 11:13
@VolkerChristian VolkerChristian changed the title Fix CI platform assumptions and Windows media cleanup Fix CI platform assumptions and Windows asset lifetime defects Oct 12, 2026
@VolkerChristian
VolkerChristian merged commit 9fce586 into main Oct 12, 2026
@VolkerChristian
VolkerChristian deleted the codex/ci-platform-tests branch October 15, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant