Repository navigation
Fix CI platform assumptions and Windows asset lifetime defects - #11
Merged
Merged
Conversation
VolkerChristian
marked this pull request as ready for review
October 12, 2026 11:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI could hang on unexpected Qt warning dialogs and failed because backend mocks, fonts and source encodings assumed Linux. Correct the test environment so failures report their actual cause, and retain real audio integration coverage with the existing audio_device marker and an isolated local sink.
Fix two Windows application defects at their ownership boundaries: PDF reload releases playback file handles before replacing the project directory and restores audio after a failed installation; draft cancellation compares asset names using the same portable format as imports so referenced media is preserved.
Validation on the approved production change:
Production net +2 lines, explicitly approved; tests net +59. Shared CI workflow, build manifest, application backend selection and physical audio settings remain unchanged.
See docs/reviews/2026-10-12-ci-platform-tests.md for exact commands, intermediate failures, environment limitations and accounting. Final documentation-only commit records these results; production/test trees match the verified commits.