Skip to content

feat: add verified integration SDK channel - #358

Merged
lzy98276 merged 6 commits into
masterfrom
codex/integration-sdk-auth-clean
Nov 22, 2026
Merged

lzy98276 merged 6 commits into
masterfrom
codex/integration-sdk-auth-clean

Conversation

@lzy98276

Copy link
Copy Markdown
Member

Overview

Adds a standalone SecRandom Integration SDK for roster and history storage, random/fair drawing, and local IPC notifications. SecRandom verifies the official ECDSA P-256 SDK proof and loaded client assembly, asks before saving a notification channel, forwards committed draw results, and supports channel removal. Linkage leases hide and restore the floating windows. Orchestrated drawing stays outside the SDK.

Verification

  • SecRandom desktop Release build with the public trust key injected: passed with 0 warnings and 0 errors
  • SecRandom Core tests: 1846 passed; the new publisher-proof test passed
  • SDK tests: 5 passed
  • Local signing proof generation verified the ignored .env private key against the public key
  • SDK GitHub Actions build: passed

Trust Configuration

Both repositories use the SECRANDOM_INTEGRATION_PUBLIC_KEY_SPKI_BASE64 Actions variable. The private signing key stays in the SDK repository Actions Secret and the ignored local .env file.

@lzy98276
lzy98276 requested a review from lrs2187 as a code owner November 21, 2026 14:27
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T14:41:37.803245Z 18b09cb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 18b09cb02d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +365 to +369
if (proof is null || proof.PackageId != OfficialPackageId || proof.SdkVersion != manifest.SdkVersion)
return false;
var key = typeof(IntegrationChannelService).Assembly.GetCustomAttributes<AssemblyMetadataAttribute>()
.FirstOrDefault(x => x.Key == "SecRandomIntegrationPublicKey")?.Value;
if (!VerifyProof(proof, key)) return false;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Bind channel consent to a verified application identity

If another process with the official SDK assembly advertises an already-approved AppId, this proof check authenticates only the SDK package and version, not the app ID. Discovery then replaces the saved endpoint and PID without prompting, allowing the new process to receive results under the first app’s consent. Bind approval to a verifiable application identity rather than trusting AppId alone.

AGENTS.md reference: SecRandom/AGENTS.md:L89-L89

Useful? React with 👍 / 👎.

},
members,
at = new DateTimeOffset(completed.DrawTime).ToUniversalTime(),
idempotency_key = completed.RoundId,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid forwarding history-suppressed draws with an empty idempotency key

When a draw pipeline handler sets SuppressHistory=true without an OverrideRoundId, the draw services publish DrawCompleted with an empty RoundId because no commit occurs. This projection still sends that value as both round_id and idempotency_key, so such results cannot be uniquely identified and may collide in the receiving integration. Skip uncommitted draws or provide a unique key.

AGENTS.md reference: SecRandom/AGENTS.md:L89-L89

Useful? React with 👍 / 👎.

@lzy98276
lzy98276 merged commit 235d742 into master Nov 22, 2026
20 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant