Repository navigation
feat: add verified integration SDK channel - #358
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 18b09cb02d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (proof is null || proof.PackageId != OfficialPackageId || proof.SdkVersion != manifest.SdkVersion) | ||
| return false; | ||
| var key = typeof(IntegrationChannelService).Assembly.GetCustomAttributes<AssemblyMetadataAttribute>() | ||
| .FirstOrDefault(x => x.Key == "SecRandomIntegrationPublicKey")?.Value; | ||
| if (!VerifyProof(proof, key)) return false; |
There was a problem hiding this comment.
Bind channel consent to a verified application identity
If another process with the official SDK assembly advertises an already-approved AppId, this proof check authenticates only the SDK package and version, not the app ID. Discovery then replaces the saved endpoint and PID without prompting, allowing the new process to receive results under the first app’s consent. Bind approval to a verifiable application identity rather than trusting AppId alone.
AGENTS.md reference: SecRandom/AGENTS.md:L89-L89
Useful? React with 👍 / 👎.
| }, | ||
| members, | ||
| at = new DateTimeOffset(completed.DrawTime).ToUniversalTime(), | ||
| idempotency_key = completed.RoundId, |
There was a problem hiding this comment.
Avoid forwarding history-suppressed draws with an empty idempotency key
When a draw pipeline handler sets SuppressHistory=true without an OverrideRoundId, the draw services publish DrawCompleted with an empty RoundId because no commit occurs. This projection still sends that value as both round_id and idempotency_key, so such results cannot be uniquely identified and may collide in the receiving integration. Skip uncommitted draws or provide a unique key.
AGENTS.md reference: SecRandom/AGENTS.md:L89-L89
Useful? React with 👍 / 👎.
Overview
Adds a standalone SecRandom Integration SDK for roster and history storage, random/fair drawing, and local IPC notifications. SecRandom verifies the official ECDSA P-256 SDK proof and loaded client assembly, asks before saving a notification channel, forwards committed draw results, and supports channel removal. Linkage leases hide and restore the floating windows. Orchestrated drawing stays outside the SDK.
Verification
.envprivate key against the public keyTrust Configuration
Both repositories use the
SECRANDOM_INTEGRATION_PUBLIC_KEY_SPKI_BASE64Actions variable. The private signing key stays in the SDK repository Actions Secret and the ignored local.envfile.