Use Box::assume_init in RBTreeNodeReservation::into_node once/if new_uninit is stabilised. #401

Activity

1. ojeda

   added

   prio: low

   • libRelated to the `rust/` library.Related to the `rust/` library.

   on Jun 29, 2021
2. ojeda

   added a commit that references this issue on Jan 16, 2023

   perf python: Don't stop building if python setuptools isn't installed

   ...

   66dfc51
3. ojeda

   removed

   prio: low

   on Feb 17, 2023
4. GuilhermeGiacomoSimoes commented on Jan 11, 2025

   

   GuilhermeGiacomoSimoes

   on Jan 11, 2025

   More actions

   @wedsonaf
   the @dakr changed this function in 2024/10/04 (git show 8373147ce4961)

   the diff

   -    pub fn into_node(mut self, key: K, value: V) -> RBTreeNode<K, V> {
   -        self.node.write(Node {
   -            key,
   -            value,
   -            links: bindings::rb_node::default(),
   -        });
   -        // SAFETY: We just wrote to it.
   -        let node = unsafe { self.node.assume_init() };
   +    pub fn into_node(self, key: K, value: V) -> RBTreeNode<K, V> {
   +        let node = KBox::write(
   +            self.node,
   +            Node {
   +                key,
   +                value,
   +                links: bindings::rb_node::default(),
   +            },
   +        );

   He was removed the self.node.assume_init() ..

   If you try pass the result of KBox::write(...) for KBox::assume_init(...) the compiler return

       --> rust/kernel/rbtree.rs:1074:27
        |
   1074 |         KBox::assume_init(node);
        |         ----------------- ^^^^ expected `Box<MaybeUninit<_>, Kmalloc>`, found `Box<Node<K, V>, Kmalloc>`
        |         |
        |         arguments to this function are incorrect
   

   Maybe this is already resolved.
5. ojeda

   added a commit that references this issue on Aug 8, 2025

   LoongArch: BPF: Add struct ops support for trampoline

   ...

   6abf17d
6. ojeda

   added a commit that references this issue on Jul 25, 2026

   KVM: x86: Fix null pointer deref due to dummy array in trace_kvm_inj_…

   ...

   9c66085