You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In general, I recommend contacting the person, even if just out of deference. If there is no reply, then you could still consider submitting their patches etc.
Moreover, it is also a good idea to mention prior work in the commit message, and discuss why you used a different approach, since the PR was discussed by a few people back then.
Activity
wcampbell0x2a commentedon May 6, 2021
Is this the API you are looking for?
ojeda commentedon May 6, 2021
Something like that, yeah!
GuilhermeGiacomoSimoes commentedon Dec 6, 2024
@ojeda
I sent a patch for this
https://lore.kernel.org/all/20241206192244.443486-1-trintaeoitogc@gmail.com/
ojeda commentedon Dec 6, 2024
Thanks!
@wcampbell0x2a submitted a PR a while ago (#904) that was reviewed etc., did you see that? I think the patches were never submitted, though.
GuilhermeGiacomoSimoes commentedon Dec 6, 2024
@ojeda
Yes, I saw that, but since @wcampbell0x2a never sent his patches, and it was a long time ago, I did the change my way and sent my patches.
ojeda commentedon Dec 6, 2024
In general, I recommend contacting the person, even if just out of deference. If there is no reply, then you could still consider submitting their patches etc.
Moreover, it is also a good idea to mention prior work in the commit message, and discuss why you used a different approach, since the PR was discussed by a few people back then.
Thanks!
rust: module: change author to be a array
rust: module: change author to be a array
rust: module: change author to an array
rust: module: change author to an array
4 remaining items
rust: module: change author to an array
rust: module: change author to an array
rust: module: change author to an array
rust: module: change author to an array
rust: module: change author to an array
rust: module: introduce `authors` key
ojeda commentedon Mar 10, 2025
https://lore.kernel.org/rust-for-linux/20250309175712.845622-1-trintaeoitogc@gmail.com/
Applied to
rust-next, so closing since it will likely land in mainline.rust: module: introduce `authors` key
rust: module: introduce `authors` key
rust: module: introduce `authors` key
rust: module: introduce `authors` key
rust: module: introduce `authors` key
rust: module: introduce `authors` key
perf trace: Increase TRACE_AUG_MAX_BUF to 128 and document beauty_map…