Skip to content

Avoid using a bunch of cfg flags and use of hardcoded auto.conf path #22

Closed
Closed
Avoid using a bunch of cfg flags and use of hardcoded auto.conf path#22

Description

@kloenk
kloenk
opened on Oct 10, 2020

Currently, building with O=$something fails as auto.conf is search for in the source tree.
Also the arguments passed as cfg parsed from auto.conf can get bigger as the max argument length of linux.

Activity

  1. kloenk commented on Oct 10, 2020

    @kloenk
    kloenk
    on Oct 10, 2020
    MemberAuthor

    For configs, that are y, do we want to pass --cfg=name="y" or do we just want --cfg=name

  2. kloenk
    added
    kernel-kconfig
    on Oct 10, 2020
  3. kloenk
    added this to the milestone on Oct 10, 2020

  4. ojeda commented on Oct 10, 2020

    @ojeda
    ojeda
    on Oct 10, 2020
    Member

    For configs, that are y, do we want to pass --cfg=name="y" or do we just want --cfg=name

    Good question. On the C side we have the IS_BUILTIN/MODULE/REACHABLE/ENABLED macros as well as just #ifdef etc.

    I guess for ease of use we could provide each CONFIG_X value for both the value and the "empty" value, i.e.:

    • For y: CONFIG_X and CONFIG_X="y".
    • For m: CONFIG_X and CONFIG_X="m".

    We can forget about the IS_REACHABLE for the moment (one can always put the equivalent predicate if needed).

    For other kinds of values (e.g. integers and strings), I don't think we want to set the CONFIG_X, but it does not hurt and would be consistent.

  5. ojeda
    added a commit that references this issue on Nov 28, 2020

    Use @file to pass the --cfg flags to rustc (fixes #22)

    df6070b

  6. ojeda commented on Nov 28, 2020

    @ojeda
    ojeda
    on Nov 28, 2020
    Member

    For configs, that are y, do we want to pass --cfg=name="y" or do we just want --cfg=name

    Good question. On the C side we have the IS_BUILTIN/MODULE/REACHABLE/ENABLED macros as well as just #ifdef etc.

    I guess for ease of use we could provide each CONFIG_X value for both the value and the "empty" value, i.e.:

    • For y: CONFIG_X and CONFIG_X="y".
    • For m: CONFIG_X and CONFIG_X="m".

    We can forget about the IS_REACHABLE for the moment (one can always put the equivalent predicate if needed).

    For other kinds of values (e.g. integers and strings), I don't think we want to set the CONFIG_X, but it does not hurt and would be consistent.

    This is handled by #32

  7. ojeda
    added a commit that references this issue on Nov 28, 2020

    Use @file to pass the --cfg flags to rustc (fixes #22)

    39484fa
  8. ojeda
    closed this as completedin 39484faon Nov 28, 2020
  9. ojeda
    added a commit that references this issue on Nov 28, 2020

    Merge pull request #32 from Rust-for-Linux/rust-cfg-file

    c28ec6f
  10. ojeda
    added a commit that references this issue on Jul 29, 2021

    xdp, net: Fix use-after-free in bpf_xdp_link_release

    5acc7d3
  11. ojeda
    added a commit that references this issue on Dec 20, 2021

    drm/msm/a6xx: Allocate enough space for GMU registers

    b4d25ab
  12. ojeda
    added a commit that references this issue on Jan 10, 2022

    Input: elantech - fix stack out of bound access in elantech_change_re…

    1d72d9f
  13. ojeda
    added a commit that references this issue on Feb 28, 2022

    net-sysfs: add check for netdevice being present to speed_show

    4224cfd
  14. ojeda
    added a commit that references this issue on Apr 12, 2022

    virtio: use virtio_device_ready() in virtio_device_restore()

    8d65bc9
  15. ojeda
    added a commit that references this issue on Dec 4, 2022

    KVM: selftests: Add tests in xen_shinfo_test to detect lock races

    a51abbb

  16. 16 remaining items

  17. ojeda
    added a commit that references this issue on Sep 29, 2025

    fs/proc/task_mmu: check p->vec_buf for NULL

    28aa299
  18. ojeda
    added a commit that references this issue on Nov 1, 2025

    fs/notify: call exportfs_encode_fid with s_umount

    a7c4bb4
  19. metaspace
    added a commit that references this issue on Nov 12, 2025

    fs/notify: call exportfs_encode_fid with s_umount

    d1894bc
  20. ojeda
    added a commit that references this issue on Nov 15, 2025

    NFSD: free copynotify stateid in nfs4_free_ol_stateid()

    4aa1714
  21. Gnurou
    added a commit that references this issue on Mar 6, 2026

    mptcp: pm: in-kernel: always mark signal+subflow endp as used

    579a752
  22. BennoLossin
    added 6 commits that reference this issue on Mar 19, 2026

    hfsplus: fix volume corruption issue for generic/498

    21b9cf5

    mptcp: pm: in-kernel: always mark signal+subflow endp as used

    198824c

    hfsplus: fix volume corruption issue for generic/498

    bccd4eb

    hfsplus: fix volume corruption issue for generic/498

    773855c

    mptcp: pm: in-kernel: always mark signal+subflow endp as used

    05799c2

    mptcp: pm: in-kernel: always mark signal+subflow endp as used

    67f34ab
  23. btpsj
    added a commit that references this issue on May 1, 2026

    apparmor: Fix string overrun due to missing termination

    828bf79
  24. Darksonn
    added a commit that references this issue on Jun 16, 2026

    mm/swap: add cond_resched() in swap_reclaim_full_clusters to prevent …

    66366d2
  25. Darksonn
    added a commit that references this issue on Jul 11, 2026

    drm/imagination: Fix double call to drm_sched_entity_fini()

    4af24c2
  26. Darksonn
    added a commit that references this issue on Jul 28, 2026

    eventpoll: pin files while checking reverse paths

    8b7e824
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions